Creates new command to report ESLint fixable rules #12517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is just a proof of concept. Needs more work. Commits from others welcome directly in this PR. |
aduth
reviewed
Mar 27, 2017
| @@ -151,6 +151,7 @@ | |||
| "test-server:watch": "nodemon -e js,jsx --exec npm run test-server", | |||
| "test-test:watch": "nodemon -e js,jsx --exec npm run test-test", | |||
| "lint": "bin/run-lint .", | |||
| "lint-fixable": "`npm bin`/eslint --ext=.js,.jsx --format=./bin/formatter.js client/ server/ test/", | |||
There was a problem hiding this comment.
You shouldn't need npm bin. The ./node_modules/.bin directory is effectively added to PATH for any npm scripts.
| @@ -0,0 +1,129 @@ | |||
| const fixableRules = [ | |||
There was a problem hiding this comment.
Is there any way to extract these automatically from our ESLint config?
|
Closing as this PR is stale - please reopen if necessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is creating a new command (tentatively
npm run lint-fixable) for reporting the ESLint fixable rules, so we can focus our janitorial efforts on them. See #8562 for context.TODO
--fixableto report only fixable rules or all (by default)