Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework: Upgrade ESLint no-console to error #9039

Merged
merged 1 commit into from
Nov 1, 2016
Merged

Framework: Upgrade ESLint no-console to error #9039

merged 1 commit into from
Nov 1, 2016

Conversation

aduth
Copy link
Contributor

@aduth aduth commented Oct 31, 2016

Related: #8562

This pull request continues the crusade to upgrade all ESLint rules to errors by resolving remaining issues with no-console rule.

Implementation notes:

Revisions include:

  • Updating console messaging to debug where appropriate
  • Avoiding direct console calls where stubbing via useSandbox test helper suffices
  • Removing test cases which don't need to test console calls themselves
  • Allow console in test and server directories

Testing Instructions:

That CircleCI passes is indication that the changes included are working as intended.

@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=remove/eslint-no-console-override

@aduth aduth added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 31, 2016
@aduth aduth force-pushed the remove/eslint-no-console-override branch from 28967b8 to 7704fb1 Compare November 1, 2016 18:09
@aduth aduth merged commit 696d6cd into master Nov 1, 2016
@aduth aduth deleted the remove/eslint-no-console-override branch November 1, 2016 18:15
@lancewillett lancewillett removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Framework [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aduth @matticbot @lancewillett