Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark private apis as private #11557

Merged
merged 2 commits into from
May 29, 2023
Merged

Mark private apis as private #11557

merged 2 commits into from
May 29, 2023

Conversation

kekekeks
Copy link
Member

Depends on #11552

@danwalmsley danwalmsley force-pushed the feature/borking-changes branch 2 times, most recently from 92212ec to 6fcf4a9 Compare May 29, 2023 18:17
maxkatz6
maxkatz6 approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@maxkatz6 maxkatz6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but we need to make PlatformSettings a public API, as it's not available from the locator anymore. Will do it in separated PR.

@maxkatz6 maxkatz6 merged commit 1ebdf25 into master May 29, 2023
@maxkatz6 maxkatz6 deleted the feature/borking-changes branch May 29, 2023 23:41
@DamianSuess DamianSuess mentioned this pull request Aug 16, 2023
Draft
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxkatz6 maxkatz6 maxkatz6 approved these changes

Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kekekeks @nref @maxkatz6 @workgroupengineering