-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup runtime platform classes #2 #11930
Conversation
Technically that might be a problem for out-of-tree backends for obscure environments. |
In Avalonia specifically, it's used only for OpenGL code. Backends for these obscure environments will likely need their special rendering either way. So I don't think it's an issue for us to solve, at least not until we support these environments officially. |
You can test this PR using the following package version. |
You can test this PR using the following package version. |
You can test this PR using the following package version. |
What does the pull request do?
There was an oversight with IRuntimePlatform being still public, when it shouldn't. This PR fixes it + removes some code from there.
Continuing #8183
Breaking changes
IRuntimePlatform
Minor breaking change, as IRuntimePlatform wasn't accessible without Locator anyway.
With this, it can be merged either now or for 11.1 without breaking any app.
Inheriting AppBuilder and creating it from ctor is not supported anymore.
This one can be an actual breaking change, but I don't see where any app would use it anyway.