Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Avalonia Properties Page #12562

Merged

Conversation

workgroupengineering
Copy link
Contributor

@workgroupengineering workgroupengineering commented Aug 16, 2023

What does the pull request do?

Add Properties Page to project properties in VS.

immagine

  • Compiling
    • EnableAvaloniaXamlCompilation
    • AvaloniaXamlIlVerifyIl
    • AvaloniaUseExternalMSBuild
    • AvaloniaUseCompiledBindingsByDefault
    • AvaloniaAccessUnstablePrivateApis
  • Debug
    • AvaloniaXamlIlDebuggerLaunch
    • AvaloniaXamlReportImportance
  • Name Genenrator
    • AvaloniaNameGeneratorIsEnabled
    • AvaloniaNameGeneratorDefaultFieldModifier
    • AvaloniaNameGeneratorFilterByPath
    • AvaloniaNameGeneratorFilterByNamespace
    • AvaloniaNameGeneratorViewFileNamingStrategy

What is the current behavior?

immagine

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

@robloo
Copy link
Contributor

robloo commented Aug 17, 2023

This is really neat! I never knew this could be done

@workgroupengineering
Copy link
Contributor Author

This is really neat! I never knew this could be done

You are right, and it is possible to add the controls to the Toolbox but currently only Winform and WPF are supported.

I'd like to try to implement the Toolbox for the VS Avalonia extension, but I'm waiting for the VS Code extension to be made public.

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0038502-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0038534-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0038593-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@workgroupengineering
Copy link
Contributor Author

@maxkatz6 Should i made other changes?

Copy link
Member

@maxkatz6 maxkatz6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I don't know if we want to merge it now or later for 11.1 or to a special 11.1 branch
@kekekeks

@cesarchefinho
Copy link

LGTM, but I don't know if we want to merge it now or later for 11.1 or to a special 11.1 branch @kekekeks

better merge now and provide better tooling for users on 11.0 too

@robloo
Copy link
Contributor

robloo commented Aug 24, 2023

I realize the focus is on bug-fixes and stabilization only for now. But this PR doesn't change anything code-related and only makes these project properties easier to discover and configure. There should be no ill-effect and will even help new users. Seems like a good candidate to merge sooner rather than later.

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0038882-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0038894-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@grokys grokys added this pull request to the merge queue Sep 13, 2023
Merged via the queue into AvaloniaUI:master with commit f430981 Sep 13, 2023
5 checks passed
@workgroupengineering workgroupengineering deleted the feature/VS/PropertiesPage branch September 13, 2023 15:07
@TomEdwardsEnscape
Copy link
Contributor

When I try out the latest nightly build, which contains these changes, I get an endless parade of binding errors. It turns out that in each project, the new property page has AvaloniaUseCompiledBindingsByDefault checked.

This feature isn't enabled by default in 11.0.4. This seems like an unintentional change.

@workgroupengineering
Copy link
Contributor Author

@TomEdwardsEnscape Thanks for the feedback, I'll look into it.

workgroupengineering added a commit to workgroupengineering/Avalonia that referenced this pull request Sep 22, 2023
fix default value AvaloniaUseCompiledBindingsByDefault segalated by AvaloniaUI#12562 (comment)
github-merge-queue bot pushed a commit that referenced this pull request Sep 23, 2023
…12987)

fix default value AvaloniaUseCompiledBindingsByDefault segalated by #12562 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants