-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Avalonia Properties Page #12562
feat: Avalonia Properties Page #12562
Conversation
This is really neat! I never knew this could be done |
You are right, and it is possible to add the controls to the Toolbox but currently only Winform and WPF are supported. I'd like to try to implement the Toolbox for the VS Avalonia extension, but I'm waiting for the VS Code extension to be made public. |
e75b622
to
9f02759
Compare
You can test this PR using the following package version. |
542ce35
to
3d28e18
Compare
You can test this PR using the following package version. |
You can test this PR using the following package version. |
@maxkatz6 Should i made other changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I don't know if we want to merge it now or later for 11.1 or to a special 11.1 branch
@kekekeks
better merge now and provide better tooling for users on 11.0 too |
I realize the focus is on bug-fixes and stabilization only for now. But this PR doesn't change anything code-related and only makes these project properties easier to discover and configure. There should be no ill-effect and will even help new users. Seems like a good candidate to merge sooner rather than later. |
You can test this PR using the following package version. |
You can test this PR using the following package version. |
When I try out the latest nightly build, which contains these changes, I get an endless parade of binding errors. It turns out that in each project, the new property page has This feature isn't enabled by default in 11.0.4. This seems like an unintentional change. |
@TomEdwardsEnscape Thanks for the feedback, I'll look into it. |
fix default value AvaloniaUseCompiledBindingsByDefault segalated by AvaloniaUI#12562 (comment)
…12987) fix default value AvaloniaUseCompiledBindingsByDefault segalated by #12562 (comment)
What does the pull request do?
Add Properties Page to project properties in VS.
AvaloniaUseExternalMSBuildAvaloniaAccessUnstablePrivateApisWhat is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues