Custom setters implement Equals/GetHashCode and have optimized code gen #8675
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This pull request updates the XamlX IL compiler to kekekeks/XamlX#65 (please see that PR for full details).
It also implements
Equals
,GetHashCode
andIXamlILOptimizedEmitablePropertySetter
on custom property setters to take advantage of the XamlX changes and generate fewer IL instructions.What is the updated/expected behavior with this PR?
Equals
andGetHashCode
overrides allow the IL compiler to cache the generated dynamic setter methods when possible.IXamlILOptimizedEmitablePropertySetter
generates smaller IL code for static setters.Everything should work the same as before, but with smaller assemblies emitted from XAML code.
Setters for
IBinding
andUnsetValueType
now useAllowRuntimeNull = false
to keep the same behavior as before (that setting wasn't respected before the XamlX PR: the generated code didn't allow null in practice).Tests
New unit tests have been added to XamlX.
Avalonia already has all the relevant tests needed, which should all pass.