Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting fails under mac #268

Closed
chenjing1294 opened this issue Oct 10, 2022 · 8 comments · Fixed by #275
Closed

Syntax highlighting fails under mac #268

chenjing1294 opened this issue Oct 10, 2022 · 8 comments · Fixed by #275

Comments

@chenjing1294
Copy link

截屏2022-10-10 上午11 40 19

@danipen
Copy link
Collaborator

danipen commented Oct 10, 2022

It's working fine in my mac...
image

What macOS version/architecture are you trying?

@chenjing1294
Copy link
Author

It's working fine in my mac... image

What macOS version/architecture are you trying?

macOS Monterey 12.6 / M1 Pro,
After I recompiled oniguruma, put it in the running directory and it returned to normal. Does it not support M1?

@danipen
Copy link
Collaborator

danipen commented Oct 10, 2022

After I recompiled oniguruma, put it in the running directory and it returned to normal. Does it not support M1?

Not sure, maybe not.

@Gillibald is the syntax highlight working for you? Are you using M1? My macOS is an intel-based one, so I cannot check that.

@chenjing1294 just to double check ... the Oniguruma bindings are provided by TextMateSharp. So ... question: is the TextMateSharp demo working for you? If the answer is no ... we would need to re-build the oniguruma bindings with M1 support.

@chenjing1294
Copy link
Author

@chenjing1294 just to double check ... the Oniguruma bindings are provided by TextMateSharp. So ... question: is the TextMateSharp demo working for you? If the answer is no ... we would need to re-build the oniguruma bindings with M1 support.

TextMateSharp demo didn't work for me until I recompiled oniguruma on M1.

@danipen
Copy link
Collaborator

danipen commented Oct 10, 2022

Oh ok, so it seems we need a new build for the oniguruma bindings.

@chenjing1294 some help would be appreciated so if you generate a universal build of the onigwrap dylib I can generate a new TextMateSharp nuget and fix the issue in AvaloniaEdit.

@danipen
Copy link
Collaborator

danipen commented Oct 15, 2022

I generated a new version of the native onigwrap library with both x64 abd arm64 support, so now macOS M1 should be supported.

I cannot test M1, so please, @chenjing1294 could you try to manually replace the native binary with this one, and check if it's working fine for M1 now? Thanks in advance!

@danipen
Copy link
Collaborator

danipen commented Oct 18, 2022

@chenjing1294 did you have a chance to test it?

@chenjing1294
Copy link
Author

@chenjing1294 did you have a chance to test it?

Great, problem solved, thank you.😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants