Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textmate nuget package built with Debug mode #304

Closed
guilhermeolisi opened this issue Feb 5, 2023 · 8 comments · Fixed by #306
Closed

Textmate nuget package built with Debug mode #304

guilhermeolisi opened this issue Feb 5, 2023 · 8 comments · Fixed by #306

Comments

@guilhermeolisi
Copy link

guilhermeolisi commented Feb 5, 2023

Hi, I'm using TextMate package from nuget in my project and when I run Windows App Certification Kit to publish to Windows store, I get a error message saying that your package's dll files were build in Debug mode. Would you publish a nuget package built with Release mode?

The version of nuget package is 0.10.12.2

@danipen
Copy link
Collaborator

danipen commented Feb 6, 2023

Do you mean this package ?

@danipen
Copy link
Collaborator

danipen commented Feb 6, 2023

Or this one ?

@guilhermeolisi
Copy link
Author

I mean this package: AvaloniaEdit.TextMate

@danipen
Copy link
Collaborator

danipen commented Feb 6, 2023

Ok. @Takoooooo please could you review if the Nugget generation uses Release mode?

@Gillibald
Copy link
Contributor

I think there is a missing: --configuration "Release" for dotnet pack

@Takoooooo
Copy link
Contributor

I think there is a missing: --configuration "Release" for dotnet pack

I guess this PR should fix it #306

@Takoooooo
Copy link
Contributor

Takoooooo commented Feb 6, 2023

We have released AvaloniaEdit 11.0.0-preview5 with the fix for this issue included,please test and verify if that fixes your issue

@guilhermeolisi
Copy link
Author

We have released AvaloniaEdit 11.0.0-preview5 with the fix for this issue included,please test and verify if that fixes your issue

Thanks for fixing this issue, but I'm using nuget package for avalonia 0.10.18 to publish in Windows store, so I can't verify if this modification (for Avalonia 11) Will receive error message from Windows App Certification Kit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants