Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CustomMargin renders incorrectly when scrolling #442

Closed
xanthome opened this issue Jul 27, 2024 · 2 comments · Fixed by #444
Closed

CustomMargin renders incorrectly when scrolling #442

xanthome opened this issue Jul 27, 2024 · 2 comments · Fixed by #444

Comments

@xanthome
Copy link

AvaloniaEdit/src/AvaloniaEdit.Demo/CustomMargin.cs

Line 115 in 934f022

double y = TextView.VerticalOffset + visualLine.VisualTop + visualLine.Height / 2;

is fixed with:
double y = visualLine.VisualTop - TextView.VerticalOffset + visualLine.Height / 2;

clicked-line10-no-scroll clicked-line10-scrolled-down clicked-line10-scrolled-down-fixed
@danipen
Copy link
Collaborator

danipen commented Jul 29, 2024

cc @mgarstenauer can you please check this?

@danipen danipen mentioned this issue Jul 29, 2024
Merged
@danipen
Copy link
Collaborator

danipen commented Jul 29, 2024

I was able to open a new PR for this. Please @mgarstenauer take a look if you can. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix customMargin renders incorrectly when scrolling AvaloniaUI/AvaloniaEdit
2 participants
@danipen @xanthome