From 111a654a67fb556346732e0476a64f91fa149f9d Mon Sep 17 00:00:00 2001
From: Daniel <dpenalba@codicesoftware.com>
Date: Fri, 3 Mar 2023 08:28:43 +0100
Subject: [PATCH 1/6] Make buttons theme agnostic

---
 src/AvaloniaEdit/Search/SearchPanel.xaml | 32 ++++++++++++------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/src/AvaloniaEdit/Search/SearchPanel.xaml b/src/AvaloniaEdit/Search/SearchPanel.xaml
index 9268959c..7d4ba723 100644
--- a/src/AvaloniaEdit/Search/SearchPanel.xaml
+++ b/src/AvaloniaEdit/Search/SearchPanel.xaml
@@ -30,8 +30,8 @@
                           VerticalAlignment="Center"
                           HorizontalAlignment="Center"
                           Height="13"
-                          Fill="{DynamicResource TextControlButtonForeground}"
-                          Stroke="{DynamicResource TextControlButtonForeground}"
+                          Fill="{TemplateBinding Foreground}"
+                          Stroke="{TemplateBinding Foreground}"
                           StrokeThickness="1" />
                 </Border>
             </ControlTemplate>
@@ -113,8 +113,8 @@
                                                       HorizontalAlignment="Center"
                                                       VerticalAlignment="Center"
                                                       Width="12"
-                                                      Fill="{DynamicResource ButtonForeground}"
-                                                      Stroke="{DynamicResource ButtonForeground}"
+                                                      Fill="{Binding $parent.Foreground}"
+                                                      Stroke="{Binding $parent.Foreground}"
                                                       StrokeThickness="1" />
                                             </ToggleButton>
                                             <ToggleButton
@@ -129,8 +129,8 @@
                                                     HorizontalAlignment="Center"
                                                     VerticalAlignment="Center"
                                                     Width="14"
-                                                    Fill="{DynamicResource ButtonForeground}"
-                                                    Stroke="{DynamicResource ButtonForeground}"
+                                                    Fill="{Binding $parent.Foreground}"
+                                                    Stroke="{Binding $parent.Foreground}"
                                                     StrokeThickness="1" />
                                             </ToggleButton>
                                             <ToggleButton
@@ -145,8 +145,8 @@
                                                     HorizontalAlignment="Center"
                                                     VerticalAlignment="Center"
                                                     Width="12"
-                                                    Fill="{DynamicResource ButtonForeground}"
-                                                    Stroke="{DynamicResource ButtonForeground}"
+                                                    Fill="{Binding $parent.Foreground}"
+                                                    Stroke="{Binding $parent.Foreground}"
                                                     StrokeThickness="1" />
                                             </ToggleButton>
                                         </StackPanel>
@@ -164,8 +164,8 @@
                                       HorizontalAlignment="Center"
                                       VerticalAlignment="Center"
                                       Width="16"
-                                      Fill="{DynamicResource ButtonForeground}"
-                                      Stroke="{DynamicResource ButtonForeground}"
+                                      Fill="{Binding $parent.Foreground}"
+                                      Stroke="{Binding $parent.Foreground}"
                                       StrokeThickness="1" />
                             </Button>
                             <Button Margin="3,0,0,0"
@@ -180,8 +180,8 @@
                                       VerticalAlignment="Center"
                                       Stretch="Uniform"
                                       Width="16"
-                                      Fill="{DynamicResource ButtonForeground}"
-                                      Stroke="{DynamicResource ButtonForeground}"
+                                      Fill="{Binding $parent.Foreground}"
+                                      Stroke="{Binding $parent.Foreground}"
                                       StrokeThickness="1" />
                             </Button>
                             <Button Margin="3,0,0,0"
@@ -195,8 +195,8 @@
                                     VerticalAlignment="Center"
                                     Stretch="Uniform"
                                     Width="12"
-                                    Fill="{DynamicResource ButtonForeground}"
-                                    Stroke="{DynamicResource ButtonForeground}"
+                                    Fill="{Binding $parent.Foreground}"
+                                    Stroke="{Binding $parent.Foreground}"
                                     StrokeThickness="1" />
                             </Button>
                         </StackPanel>
@@ -226,7 +226,7 @@
                                     VerticalAlignment="Center"
                                     Stretch="Uniform"
                                     Width="12"
-                                    Fill="{DynamicResource ButtonForeground}"
+                                    Fill="{Binding $parent.Foreground}"
                                     StrokeThickness="1" />
                             </Button>
                             <Button Margin="3, 0, 0, 0"
@@ -242,7 +242,7 @@
                                     VerticalAlignment="Center"
                                     Stretch="Uniform"
                                     Width="18"
-                                    Fill="{DynamicResource ButtonForeground}" />
+                                    Fill="{Binding $parent.Foreground}" />
                             </Button>
                         </StackPanel>
                         <StackPanel Name="PART_MessageView"

From a54f1db5237b981661ac6a8ae1c957eb389e3b8f Mon Sep 17 00:00:00 2001
From: Daniel <dpenalba@codicesoftware.com>
Date: Fri, 3 Mar 2023 09:45:48 +0100
Subject: [PATCH 2/6] Extract themed properties and create simple and theme
 variants

---
 src/AvaloniaEdit/AvaloniaEdit.xaml       | 22 +++++++++++++++-------
 src/AvaloniaEdit/Search/SearchPanel.xaml |  8 ++++----
 src/AvaloniaEdit/Themes/Fluent/Base.xaml | 16 ++++++++++++++++
 src/AvaloniaEdit/Themes/Simple/Base.xaml | 16 ++++++++++++++++
 4 files changed, 51 insertions(+), 11 deletions(-)
 create mode 100644 src/AvaloniaEdit/Themes/Fluent/Base.xaml
 create mode 100644 src/AvaloniaEdit/Themes/Simple/Base.xaml

diff --git a/src/AvaloniaEdit/AvaloniaEdit.xaml b/src/AvaloniaEdit/AvaloniaEdit.xaml
index 5ab89fb4..0f4c8eaa 100644
--- a/src/AvaloniaEdit/AvaloniaEdit.xaml
+++ b/src/AvaloniaEdit/AvaloniaEdit.xaml
@@ -1,11 +1,19 @@
 <Styles xmlns="https://github.com/avaloniaui">
 
-    <StyleInclude Source="avares://AvaloniaEdit/TextEditor.xaml" />
-    <StyleInclude Source="avares://AvaloniaEdit/Editing/TextArea.xaml" />
-    <StyleInclude Source="avares://AvaloniaEdit/CodeCompletion/CompletionList.xaml" />
-    <StyleInclude Source="avares://AvaloniaEdit/CodeCompletion/InsightWindow.xaml" />
-    <StyleInclude Source="avares://AvaloniaEdit/Rendering/VisualLineDrawingVisual.xaml" />
-    <StyleInclude Source="avares://AvaloniaEdit/Search/DropDownButton.xaml" />
-    <StyleInclude Source="avares://AvaloniaEdit/Search/SearchPanel.xaml" />
+  <Styles.Resources>
+    <ResourceDictionary>
+      <ResourceDictionary.MergedDictionaries>
+        <MergeResourceInclude Source="/Themes/Fluent/Base.xaml" />
+      </ResourceDictionary.MergedDictionaries>
+    </ResourceDictionary>
+  </Styles.Resources>
+
+  <StyleInclude Source="avares://AvaloniaEdit/TextEditor.xaml" />
+  <StyleInclude Source="avares://AvaloniaEdit/Editing/TextArea.xaml" />
+  <StyleInclude Source="avares://AvaloniaEdit/CodeCompletion/CompletionList.xaml" />
+  <StyleInclude Source="avares://AvaloniaEdit/CodeCompletion/InsightWindow.xaml" />
+  <StyleInclude Source="avares://AvaloniaEdit/Rendering/VisualLineDrawingVisual.xaml" />
+  <StyleInclude Source="avares://AvaloniaEdit/Search/DropDownButton.xaml" />
+  <StyleInclude Source="avares://AvaloniaEdit/Search/SearchPanel.xaml" />
 
 </Styles>
\ No newline at end of file
diff --git a/src/AvaloniaEdit/Search/SearchPanel.xaml b/src/AvaloniaEdit/Search/SearchPanel.xaml
index 7d4ba723..d4de6ad2 100644
--- a/src/AvaloniaEdit/Search/SearchPanel.xaml
+++ b/src/AvaloniaEdit/Search/SearchPanel.xaml
@@ -60,12 +60,12 @@
     <Style Selector="search|SearchPanel">
         <Setter Property="BorderThickness" Value="1 0 1 1" />
         <Setter Property="CornerRadius" Value="0 0 4 4" />
-        <Setter Property="BorderBrush" Value="{DynamicResource SystemControlForegroundBaseLowBrush}" />
-        <Setter Property="Background" Value="{DynamicResource SystemControlBackgroundChromeMediumBrush}" />
+        <Setter Property="BorderBrush" Value="{DynamicResource SearchPanelBorderBrush}" />
+        <Setter Property="Background" Value="{DynamicResource SearchPanelBackgroundBrush}" />
         <Setter Property="Focusable" Value="True" />
         <Setter Property="Margin" Value="0 0 18 0" />
-        <Setter Property="FontSize" Value="{DynamicResource ControlContentThemeFontSize}" />
-        <Setter Property="FontFamily" Value="{DynamicResource ContentControlThemeFontFamily}" />
+        <Setter Property="FontSize" Value="{DynamicResource SearchPanelFontSize}" />
+        <Setter Property="FontFamily" Value="{DynamicResource SearchPanelFontFamily}" />
         <Setter Property="Template">
             <ControlTemplate>
                 <Border Name="PART_Border"
diff --git a/src/AvaloniaEdit/Themes/Fluent/Base.xaml b/src/AvaloniaEdit/Themes/Fluent/Base.xaml
new file mode 100644
index 00000000..5490f759
--- /dev/null
+++ b/src/AvaloniaEdit/Themes/Fluent/Base.xaml
@@ -0,0 +1,16 @@
+<ResourceDictionary xmlns="https://github.com/avaloniaui"
+                    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
+                    xmlns:sys="using:System">
+  <StaticResource x:Key="SearchPanelFontSize" ResourceKey="ControlContentThemeFontSize" />
+  <StaticResource x:Key="SearchPanelFontFamily" ResourceKey="ContentControlThemeFontFamily" />
+  <ResourceDictionary.ThemeDictionaries>
+    <ResourceDictionary x:Key="Default">
+      <SolidColorBrush x:Key="SearchPanelBackgroundBrush" Color="{DynamicResource SystemChromeMediumColor}" />
+      <SolidColorBrush x:Key="SearchPanelBorderBrush" Color="{DynamicResource SystemBaseLowColor}" />
+    </ResourceDictionary>
+    <ResourceDictionary x:Key="Dark">
+      <SolidColorBrush x:Key="SearchPanelBackgroundBrush" Color="{DynamicResource SystemChromeMediumColor}" />
+      <SolidColorBrush x:Key="SearchPanelBorderBrush" Color="{DynamicResource SystemBaseLowColor}" />
+    </ResourceDictionary>
+  </ResourceDictionary.ThemeDictionaries>
+</ResourceDictionary>
\ No newline at end of file
diff --git a/src/AvaloniaEdit/Themes/Simple/Base.xaml b/src/AvaloniaEdit/Themes/Simple/Base.xaml
new file mode 100644
index 00000000..10bababf
--- /dev/null
+++ b/src/AvaloniaEdit/Themes/Simple/Base.xaml
@@ -0,0 +1,16 @@
+<ResourceDictionary xmlns="https://github.com/avaloniaui"
+                    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
+                    xmlns:sys="using:System">
+    <StaticResource x:Key="SearchPanelFontSize" ResourceKey="FontSizeNormal" />
+    <StaticResource x:Key="SearchPanelFontFamily" ResourceKey="ContentControlThemeFontFamily" />
+    <ResourceDictionary.ThemeDictionaries>
+        <ResourceDictionary x:Key="Default">
+            <SolidColorBrush x:Key="SearchPanelBackgroundBrush" Color="{DynamicResource ThemeBackgroundColor}" />
+            <SolidColorBrush x:Key="SearchPanelBorderBrush" Color="{DynamicResource ThemeBorderLowColor}" />
+        </ResourceDictionary>
+        <ResourceDictionary x:Key="Dark">
+            <SolidColorBrush x:Key="SearchPanelBackgroundBrush" Color="{DynamicResource ThemeBackgroundColor}" />
+            <SolidColorBrush x:Key="SearchPanelBorderBrush" Color="{DynamicResource ThemeBorderLowColor}" />
+        </ResourceDictionary>
+    </ResourceDictionary.ThemeDictionaries>
+</ResourceDictionary>
\ No newline at end of file

From d2c824c5fe83c9e677756171cb729b090bb73702 Mon Sep 17 00:00:00 2001
From: Daniel <dpenalba@codicesoftware.com>
Date: Mon, 6 Mar 2023 08:28:27 +0100
Subject: [PATCH 3/6] Prepare demo app to support themes

---
 src/AvaloniaEdit.Demo/MainWindow.xaml | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/AvaloniaEdit.Demo/MainWindow.xaml b/src/AvaloniaEdit.Demo/MainWindow.xaml
index f5796d9c..4fb785f3 100644
--- a/src/AvaloniaEdit.Demo/MainWindow.xaml
+++ b/src/AvaloniaEdit.Demo/MainWindow.xaml
@@ -5,8 +5,7 @@
         MinHeight="300"
         Width="950"
         Title="AvaloniaEdit Demo"
-        x:Class="AvaloniaEdit.Demo.MainWindow"
-        Background="#1E1E1E">
+        x:Class="AvaloniaEdit.Demo.MainWindow">
     <DockPanel>
         <StackPanel Orientation="Horizontal"
                     DockPanel.Dock="Top"
@@ -14,7 +13,7 @@
                     Margin="3">
             <ToggleButton Name="wordWrap" ToolTip.Tip="Word wrap" IsChecked="{Binding #Editor.WordWrap}">
                 <ToggleButton.Content>
-                    <Path Fill="White" Data="M2.75 5C2.33579 5 2 5.33579 2 5.75C2 6.16421 2.33579 6.5 2.75 6.5H21.25C21.6642 6.5 22 6.16421 22 5.75C22 5.33579 21.6642 5 21.25 5H2.75Z M2.75 11.5C2.33579 11.5 2 11.8358 2 12.25C2 12.6642 2.33579 13 2.75 13H19C20.3807 13 21.5 14.1193 21.5 15.5C21.5 16.8807 20.3807 18 19 18H14.5607L15.2803 17.2803C15.5732 16.9874 15.5732 16.5126 15.2803 16.2197C14.9874 15.9268 14.5126 15.9268 14.2197 16.2197L12.2197 18.2197C11.9268 18.5126 11.9268 18.9874 12.2197 19.2803L14.2197 21.2803C14.5126 21.5732 14.9874 21.5732 15.2803 21.2803C15.5732 20.9874 15.5732 20.5126 15.2803 20.2197L14.5607 19.5H19C21.2091 19.5 23 17.7091 23 15.5C23 13.2909 21.2091 11.5 19 11.5H2.75Z M2 18.75C2 18.3358 2.33579 18 2.75 18H9.25C9.66421 18 10 18.3358 10 18.75C10 19.1642 9.66421 19.5 9.25 19.5H2.75C2.33579 19.5 2 19.1642 2 18.75Z" />
+                    <Path Fill="{Binding $parent.Foreground}" Data="M2.75 5C2.33579 5 2 5.33579 2 5.75C2 6.16421 2.33579 6.5 2.75 6.5H21.25C21.6642 6.5 22 6.16421 22 5.75C22 5.33579 21.6642 5 21.25 5H2.75Z M2.75 11.5C2.33579 11.5 2 11.8358 2 12.25C2 12.6642 2.33579 13 2.75 13H19C20.3807 13 21.5 14.1193 21.5 15.5C21.5 16.8807 20.3807 18 19 18H14.5607L15.2803 17.2803C15.5732 16.9874 15.5732 16.5126 15.2803 16.2197C14.9874 15.9268 14.5126 15.9268 14.2197 16.2197L12.2197 18.2197C11.9268 18.5126 11.9268 18.9874 12.2197 19.2803L14.2197 21.2803C14.5126 21.5732 14.9874 21.5732 15.2803 21.2803C15.5732 20.9874 15.5732 20.5126 15.2803 20.2197L14.5607 19.5H19C21.2091 19.5 23 17.7091 23 15.5C23 13.2909 21.2091 11.5 19 11.5H2.75Z M2 18.75C2 18.3358 2.33579 18 2.75 18H9.25C9.66421 18 10 18.3358 10 18.75C10 19.1642 9.66421 19.5 9.25 19.5H2.75C2.33579 19.5 2 19.1642 2 18.75Z" />
                 </ToggleButton.Content>
             </ToggleButton>
             <ToggleButton Name="viewTabs" Content="View tabs" IsChecked="{Binding #Editor.Options.ShowTabs}" VerticalAlignment="Stretch" VerticalContentAlignment="Center"/>
@@ -27,7 +26,7 @@
             <Button Name="changeThemeBtn" Content="Change theme" VerticalAlignment="Stretch" VerticalContentAlignment="Center"/>
         </StackPanel>
         <StackPanel Name="StatusBar" Background="Purple" Height="25" DockPanel.Dock="Bottom" Orientation="Horizontal">
-            <TextBlock Name="StatusText" Text="Ready" Margin="5 0 0 0" VerticalAlignment="Center" FontSize="12"/>
+            <TextBlock Foreground="White" Name="StatusText" Text="Ready" Margin="5 0 0 0" VerticalAlignment="Center" FontSize="12"/>
         </StackPanel>
         <AvalonEdit:TextEditor Name="Editor"
                                FontFamily="Cascadia Code,Consolas,Menlo,Monospace"

From f9b2e57460b2d6beffdab1594f6ed7eaa00b1d49 Mon Sep 17 00:00:00 2001
From: Daniel <dpenalba@codicesoftware.com>
Date: Mon, 6 Mar 2023 08:28:58 +0100
Subject: [PATCH 4/6] Move AvaloniaEdit.xaml inside themes and create a new one
 for simple theme

---
 .../{ => Themes/Fluent}/AvaloniaEdit.xaml     |  0
 .../Themes/Simple/AvaloniaEdit.xaml           | 19 +++++++++++++++++++
 2 files changed, 19 insertions(+)
 rename src/AvaloniaEdit/{ => Themes/Fluent}/AvaloniaEdit.xaml (100%)
 create mode 100644 src/AvaloniaEdit/Themes/Simple/AvaloniaEdit.xaml

diff --git a/src/AvaloniaEdit/AvaloniaEdit.xaml b/src/AvaloniaEdit/Themes/Fluent/AvaloniaEdit.xaml
similarity index 100%
rename from src/AvaloniaEdit/AvaloniaEdit.xaml
rename to src/AvaloniaEdit/Themes/Fluent/AvaloniaEdit.xaml
diff --git a/src/AvaloniaEdit/Themes/Simple/AvaloniaEdit.xaml b/src/AvaloniaEdit/Themes/Simple/AvaloniaEdit.xaml
new file mode 100644
index 00000000..274f991e
--- /dev/null
+++ b/src/AvaloniaEdit/Themes/Simple/AvaloniaEdit.xaml
@@ -0,0 +1,19 @@
+<Styles xmlns="https://github.com/avaloniaui">
+
+  <Styles.Resources>
+    <ResourceDictionary>
+      <ResourceDictionary.MergedDictionaries>
+        <MergeResourceInclude Source="/Themes/Simple/Base.xaml" />
+      </ResourceDictionary.MergedDictionaries>
+    </ResourceDictionary>
+  </Styles.Resources>
+
+  <StyleInclude Source="avares://AvaloniaEdit/TextEditor.xaml" />
+  <StyleInclude Source="avares://AvaloniaEdit/Editing/TextArea.xaml" />
+  <StyleInclude Source="avares://AvaloniaEdit/CodeCompletion/CompletionList.xaml" />
+  <StyleInclude Source="avares://AvaloniaEdit/CodeCompletion/InsightWindow.xaml" />
+  <StyleInclude Source="avares://AvaloniaEdit/Rendering/VisualLineDrawingVisual.xaml" />
+  <StyleInclude Source="avares://AvaloniaEdit/Search/DropDownButton.xaml" />
+  <StyleInclude Source="avares://AvaloniaEdit/Search/SearchPanel.xaml" />
+
+</Styles>
\ No newline at end of file

From 23cd845d873f61c2373c6d362f6137bedb9d00cc Mon Sep 17 00:00:00 2001
From: Daniel <dpenalba@codicesoftware.com>
Date: Mon, 6 Mar 2023 08:29:10 +0100
Subject: [PATCH 5/6] Fix StyleInclude

---
 src/AvaloniaEdit.Demo/App.xaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/AvaloniaEdit.Demo/App.xaml b/src/AvaloniaEdit.Demo/App.xaml
index 015ce7d6..cac279c1 100644
--- a/src/AvaloniaEdit.Demo/App.xaml
+++ b/src/AvaloniaEdit.Demo/App.xaml
@@ -5,7 +5,7 @@
              RequestedThemeVariant="Dark">
   <Application.Styles>
     <FluentTheme />
-    <StyleInclude Source="avares://AvaloniaEdit/AvaloniaEdit.xaml" />
+    <StyleInclude Source="avares://AvaloniaEdit/Themes/Fluent/AvaloniaEdit.xaml" />
 
     <!--Code completion-->
     <Style Selector="cc|CompletionList">

From 78321291d75b42aa9a765d5d94869d855c235c7f Mon Sep 17 00:00:00 2001
From: Daniel <dpenalba@codicesoftware.com>
Date: Mon, 6 Mar 2023 08:41:13 +0100
Subject: [PATCH 6/6] Do not use hardcoded color for TextEditor's foreground

---
 src/AvaloniaEdit.Demo/MainWindow.xaml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/AvaloniaEdit.Demo/MainWindow.xaml b/src/AvaloniaEdit.Demo/MainWindow.xaml
index 4fb785f3..bd5109c8 100644
--- a/src/AvaloniaEdit.Demo/MainWindow.xaml
+++ b/src/AvaloniaEdit.Demo/MainWindow.xaml
@@ -31,7 +31,6 @@
         <AvalonEdit:TextEditor Name="Editor"
                                FontFamily="Cascadia Code,Consolas,Menlo,Monospace"
                                Margin="30"
-                               Foreground="#D4D4D4"
                                HorizontalScrollBarVisibility="Auto"
                                VerticalScrollBarVisibility="Visible"
                                FontWeight="Light"