From 3bb20a3c66754f848ece0c9be08a30f1b1896f09 Mon Sep 17 00:00:00 2001
From: sklppy88 <esau@aztecprotocol.com>
Date: Tue, 13 Aug 2024 10:11:11 +0000
Subject: [PATCH] addressing comments

---
 .../aztec-nr/aztec/src/oracle/header.nr       | 39 ++++++++++---------
 1 file changed, 21 insertions(+), 18 deletions(-)

diff --git a/noir-projects/aztec-nr/aztec/src/oracle/header.nr b/noir-projects/aztec-nr/aztec/src/oracle/header.nr
index ff027c1a78e9..e3407996dd7d 100644
--- a/noir-projects/aztec-nr/aztec/src/oracle/header.nr
+++ b/noir-projects/aztec-nr/aztec/src/oracle/header.nr
@@ -15,17 +15,17 @@ unconstrained pub fn get_header_at_internal(block_number: u32) -> Header {
 }
 
 pub fn get_header_at(block_number: u32, context: PrivateContext) -> Header {
-    let historical_header = context.historical_header;
-    let historical_block_number = historical_header.global_variables.block_number as u32;
+    let header = context.historical_header;
+    let current_block_number = header.global_variables.block_number as u32;
 
-    if (block_number == historical_block_number) {
+    if (block_number == current_block_number) {
         // If the block number we want to prove against is the same as the block number in the historical header we
         // skip the inclusion proofs and just return the historical header from context.
-        historical_header
+        header
     } else {
         // 1) Get block number corresponding to the last_archive root in the header
         // Note: We subtract 1 because the last_archive root is the root of the archive after applying the previous block
-        let last_archive_block_number = historical_block_number - 1;
+        let last_archive_block_number = current_block_number - 1;
 
         // 2) Check that the last archive block number is more than or equal to the block number we want to prove against
         // We could not perform the proof otherwise because the last archive root from the header would not "contain"
@@ -35,19 +35,19 @@ pub fn get_header_at(block_number: u32, context: PrivateContext) -> Header {
         );
 
         // 3) Get the header hint of a given block from an oracle
-        let header_hint = get_header_at_internal(block_number);
+        let historical = get_header_at_internal(block_number);
 
         // 4) We make sure that the header hint we received from the oracle exists in the state tree and is the actual header
         // at the desired block number
         constrain_get_header_at_internal(
-            header_hint,
+            historical,
             block_number,
             last_archive_block_number,
-            historical_header.last_archive.root
+            header.last_archive.root
         );
 
-        // 8) Return the block header
-        header_hint
+        // 5) Return the block header
+        historical
     }
 }
 
@@ -78,15 +78,18 @@ fn constrain_get_header_at_internal(
 fn fetching_a_valid_but_different_header_should_fail() {
     let mut env = TestEnvironment::new();
 
-    // We get an arbitrary header at block 1
-    let old_header = get_header_at_internal(1);
+    env.advance_block_to(3);
 
-    // The next call to getHeader at block 5 should resolve with this old header.
-    // This header exists, but we make the call return it at an incorrect block number.
-    let _ = OracleMock::mock("getHeader").with_params((5)).returns(old_header.serialize()).times(1);
+    // We get our current header for the last archive values.
+    let current_header = env.private().historical_header;
 
-    env.advance_block_to(6);
+    let historical_header = get_header_at_internal(1);
 
-    // We now try to get the header that our mock sets up. The oracle returns the old, incorrect header and should fail.
-    let _ = get_header_at(5, env.private());
+    // We pass in a different block number than the header received
+    constrain_get_header_at_internal(
+        historical_header,
+        2,
+        current_header.global_variables.block_number as u32 - 1,
+        current_header.last_archive.root
+    );
 }