Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derived serde traits are not found when processing macros #10321

Closed
nventuro opened this issue Nov 29, 2024 · 2 comments
Closed

Derived serde traits are not found when processing macros #10321

nventuro opened this issue Nov 29, 2024 · 2 comments

Comments

@nventuro
Copy link
Contributor

nventuro commented Nov 29, 2024

As mentioned in #10320, we apparently cannot use derive[Serialize] for types that we then search for said impl in the macros, as it is not found. I imagine this has to do with the timing of the derive expansion and our own macros. I'm not sure how we should handle this.

@TomAFrench
Copy link
Member

Yep, this is due to ordering of macros. We've got some work in progress on defining an ordering for macros which will allow this issue to be resolved here.

This PR is ready to be reviewed but before we merge it into master we need to see how much it will break aztec-packages and with *gestures at current state of the noir sync* we don't have a ton of bandwidth.

@nventuro
Copy link
Contributor Author

nventuro commented Dec 2, 2024

Ah brilliant. I'm closing this then, thank you!

@nventuro nventuro closed this as completed Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants