bug: Add support to pass notes as argument

[LHerskind]

Currently it seems unsupported to pass a note into a contract as an argument. This can be useful for certain cases, and should be supported.

[sklppy88]

Update:

This was tested, and the crux of the issue is that

assert(args_hash == item.public_inputs.args_hash);

in yarn-project/aztec-nr/aztec/src/context.nr would fail.

This was isolated down into an issue when a note is passed through as an argument. When args are serialized in typescript, they are serialized with the header, (as a whole arg) but when the actual note is serialized via the macro, the serialize function on the note is used, and this function only includes the content of the note and not the header. The hashes do not match because the preimage does not match and therefore the context catches this mismatch, throwing an error.

[LHerskind]

One way to solve the issue would be to replace the current serialize functions of the notes with serialize_content functions, and then have a serialize that serializes the entire note (with header) which is used for the argument serialization.

[rahul-kothari]

FYI - this should also handle the case of passing note even in public domain.

Here we have an interesting issue -> only unencrypted notes should be allowed to pass though right?

[LHerskind]

With #4383 it is possible to define a serialize for the note such that it can be passed in directly. It is a little strange to do, since the header will be populated as the note is inserted, but it can be useful for inclusion proofs etc.

[rahul-kothari]

Do we need an e2e here that checks that notes are passable in the pub/private domain