Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(avm): handle debuglog #6630

Merged
merged 1 commit into from
May 28, 2024
Merged

feat(avm): handle debuglog #6630

merged 1 commit into from
May 28, 2024

Conversation

fcarreiro
Copy link
Contributor

@fcarreiro fcarreiro commented May 23, 2024 •
edited
Loading

Handle it by not doing anything*. Also add deserialization for a bunch of other opcodes.

*actually we insert a JUMP instead.

@fcarreiro Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on Graphite Graphite

@fcarreiro fcarreiro requested a review from IlyasRidhuan May 23, 2024 10:13
@fcarreiro fcarreiro force-pushed the fc/avm-debug-log-deser branch 2 times, most recently from c6fcc71 to b57aa18 Compare May 23, 2024 14:46
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 23, 2024 •
edited
Loading

Changes to circuit sizes

Generated at commit: 87ddde200f64579a5481e62aafa57ef73bc5da98, compared to commit: 5ba48fcd58a1ba801dc69e15fac50c3a7b82817d

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
public_kernel_setup +1,616 ❌ +0.73% +1,842 ❌ +0.12%
public_kernel_app_logic +1,749 ❌ +0.70% +777 ❌ +0.05%
public_kernel_teardown -26,945 ✅ -10.75% -128,443 ✅ -7.91%
Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
public_kernel_setup 223,608 (+1,616) +0.73% 1,494,524 (+1,842) +0.12%
public_kernel_app_logic 252,148 (+1,749) +0.70% 1,623,637 (+777) +0.05%
public_kernel_teardown 223,814 (-26,945) -10.75% 1,494,818 (-128,443) -7.91%

@fcarreiro fcarreiro force-pushed the fc/avm-debug-log-deser branch from b57aa18 to 00ec10a Compare May 23, 2024 15:40
@fcarreiro fcarreiro merged commit eba345b into master May 28, 2024
82 of 83 checks passed
@fcarreiro fcarreiro deleted the fc/avm-debug-log-deser branch May 28, 2024 12:25
@fcarreiro Graphite App
Copy link
Contributor Author

Merge activity

@AztecBot AztecBot mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IlyasRidhuan IlyasRidhuan IlyasRidhuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fcarreiro @IlyasRidhuan