-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New custom policy DenyAction Delete UAMI used by AMA #1662
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Springstone
added
Area: Diagnostic Settings
Area: Policy 📝
Issues / PR's related to Policy
Status: PR Safe To Test ☑️
PRs can run deployment tests
and removed
Area: Diagnostic Settings
labels
Jun 6, 2024
Springstone
requested changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arjenhuitema looks, great, some minor text adjustments, kindly review.
src/resources/Microsoft.Authorization/policyDefinitions/DenyAction-DeleteResources.json
Outdated
Show resolved
Hide resolved
src/resources/Microsoft.Authorization/policyDefinitions/DenyAction-DeleteResources.json
Outdated
Show resolved
Hide resolved
…tion-DeleteResources.json Co-authored-by: Sacha Narinx <[email protected]>
…tion-DeleteResources.json Co-authored-by: Sacha Narinx <[email protected]>
Co-authored-by: Sacha Narinx <[email protected]>
Co-authored-by: Sacha Narinx <[email protected]>
Co-authored-by: Sacha Narinx <[email protected]>
Springstone
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jtracey93
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Policy 📝
Issues / PR's related to Policy
Status: PR Safe To Test ☑️
PRs can run deployment tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
New custom policy to safeguard against accidental removal of the User Assigned Managed Identity used by AMA by blocking delete calls using deny action effect.
This PR fixes/adds/changes/removes
Breaking Changes
N/A
Testing Evidence
Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
Deployment:
Assignment:
Action denied:
Testing URLs
Azure Public
As part of this Pull Request I have
main
branch/docs/wiki/whats-new.md
)