New policy build workflow #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: Update build scripts to generate policy files and role definit…
chore: Remove JSON metadata from policy template
MSRCUpdate
jtracey93
requested changes
Aug 14, 2024
microsoft-github-policy-service
bot
added
Needs: Author Feedback
and removed
Needs: Author Feedback
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several significant changes to the PowerShell scripts and GitHub workflows to improve policy management and testing. The key changes include the addition of new functions for JSON handling in PowerShell, new unit tests for policy builds, a new workflow for checking policy builds, and the removal of an outdated workflow.
New Functions for JSON Handling:
Remove-JSONMetadatafunction to remove metadata from JSON objects and handle nested templates. (.github/actions-pester/PolicyPesterTestHelper.psm1)ConvertTo-OrderedHashtablefunction to convert JSON strings to ordered hashtables, ensuring consistent key order. (.github/actions-pester/PolicyPesterTestHelper.psm1)New Unit Tests:
UnitTest-BuildPoliciesto validate that policy, initiative, and role definition builds match the expected output. (.github/actions-pester/Test-BuildPolicies.Tests.ps1)New Workflow for Policy Build Checks:
check-policy-build.ymlworkflow to automatically check policy builds on pull requests. (.github/workflows/check-policy-build.yml)Removed Outdated Workflow:
update-portal.ymlworkflow, which was responsible for updating the portal experience on pull requests. (.github/workflows/update-portal.yml)