Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Orchestrator version should accept "v" in validation and remove it #2331

Closed
CecileRobertMichon opened this issue Feb 23, 2018 · 0 comments · Fixed by #2344
Closed

Orchestrator version should accept "v" in validation and remove it #2331

CecileRobertMichon opened this issue Feb 23, 2018 · 0 comments · Fixed by #2344
Assignees
@CecileRobertMichon

Comments

@CecileRobertMichon
Copy link
Contributor

Is this a request for help?:

Is this an ISSUE or FEATURE REQUEST? (choose one):
FEATURE REQUEST

What version of acs-engine?:
v0.13.0

Orchestrator and version (e.g. Kubernetes, DC/OS, Swarm)
All?

orchestratorVersion should allow version strings in format "vx.x.x in both generate and deploy validation flows. The v should be removed from the orchestratorVersion (eg, "v1.9.3" become "1.9.3").

Right now, generate throws an error Error returned by LoadContainerService: OrchestratorProfile is not able to be rationalized, check supported Release or Version while deploy deploys a cluster with the default version instead.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@CecileRobertMichon CecileRobertMichon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow "v" prefix in orchestrator version and release CecileRobertMichon/acs-engine
1 participant
@CecileRobertMichon