This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Install azure-vnet CNI plugin on K8S Windows agents #1505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
JiangtianLi
reviewed
Sep 29, 2017
parts/kuberneteswindowssetup.ps1
Outdated
|
|
||
| $global:NetworkPolicy = "{{WrapAsVariable "networkPolicy"}}" | ||
| $global:VnetIntegration = "{{WrapAsVariable "vnetIntegration"}}" | ||
| $global:VNetCNIPluginsURL = "{{WrapAsVariable "vnetCniWindowsPluginsURL"}}" |
There was a problem hiding this comment.
What is the default value of this URL and how is the plugin zip uploaded/tested?
There was a problem hiding this comment.
The default value is specified in:
acs-engine/pkg/acsengine/defaults.go
Line 21 in 8949e3f
It is up to you to decide which version to upload to your ACS mirror. I believe Dmitry has some test coverage, in addition to the unit tests in the CNI plugin repo.
|
@JiangtianLi Please mark this PR with "do-not-merge". It should not be merged until Windows team can test it with RS3 builds and make any necessary modifications in kuberneteswindowssetup.ps1. |
jackfrancis
force-pushed
the
k8s-windows-vnet-integration
branch
from
6cc4fcc
to
64db690
Compare
ghost
assigned 
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds the logic to download, install and configure Azure VNET CNI plugins on Kubernetes Windows nodes. It brings Windows nodes to CNI-networking parity with Linux nodes in Kubernetes.
It also adds support for the "maxPods" kubelet parameter on Windows nodes.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #1504Special notes for your reviewer:
This PR updates kuberneteswindowssetup.ps1 (runs on Windows nodes first boot) with the same logic in kubernetesmastercustomscript.sh (runs on Linux nodes first boot).
I am marking the PR "do-not-merge" for now, because
Release note:
@anhowe, @lachie83, @nisheeth-ms, @sharmasushant, @tamilmani1989, @dineshgovindasamy
fixes #1504.