Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webapp:azure-cli 2.0.66 cryptography <2.5 and >2.5 #9629

Closed
ctaggart opened this issue Jun 11, 2019 · 7 comments
Closed

webapp:azure-cli 2.0.66 cryptography <2.5 and >2.5 #9629

ctaggart opened this issue Jun 11, 2019 · 7 comments
Assignees

Comments

@ctaggart
Copy link

azure-cli 2.0.66 from pypi requires cryptography <2.5 and >=2.5. 😢

azure-cli-core is requiring >=2.5 becauseof paramiko:

    - azure-cli-core [required: Any, installed: 2.0.66]
      - paramiko [required: >=2.0.8, installed: 2.5.0]
        - cryptography [required: >=2.5, installed: 2.4.2]

It is azure-cli-appservice that is putting a dependency on <2.5 here and should probably be fixed.

  - azure-cli-appservice [required: ==0.2.20, installed: 0.2.20]
    - cryptography [required: <2.5, installed: 2.4.2]

I ran into this bug and diagnosed it with pipenv.

@tjprescott
Copy link
Member

Hi @ctaggart this has been fixed as part of #9612

@tjprescott
Copy link
Member

@panchagnula is there a reason that azure-cli-appservice required cryptography < 2.5?

@tjprescott
Copy link
Member

Leaving open for @marstr to weigh in on.

@ctaggart
Copy link
Author

It looks like the change was done to suppress some warning at the time. With the updated version of paramiko, I doubt this is needed anymore. @patricklee2 @yugangw-msft

@panchagnula
Copy link
Contributor

@patricklee2 - assigning this to you to weigh in on this & make the update if needed. //CC: @rramachand21

@panchagnula panchagnula changed the title azure-cli 2.0.66 cryptography <2.5 and >2.5 webapp:azure-cli 2.0.66 cryptography <2.5 and >2.5 Jun 11, 2019
@marstr
Copy link
Member

marstr commented Jun 11, 2019

Looks to me like paramiko and cryptography are playing nice now. I believe the appropriate fix is to remove the ceiling from the appservice package. Whatever changes are made, I'll make sure it gets applied to the flatten branch as well.

@patricklee2
Copy link
Contributor

I'll make the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants