-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scope ScriptJwtBearerHandler logs to system-only #10617
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run host.public |
Azure Pipelines successfully started running 1 pipeline(s). |
liliankasem
approved these changes
Nov 12, 2024
brettsam
approved these changes
Nov 13, 2024
fabiocav
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jviau |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #10532
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-proc
branch to be included in Core Tools and non-Flex deployments.in-proc
branch is not requiredrelease_notes.md
Additional information
As part of our changes to DI in the out-of-proc host many components now resolve loggers from the job host, which includes customer logs. This was intentional and what we wanted for the most part. However, we have identified that
JwtBearerHandler
for script auth produces noisy logs which are distracting to have in customer logs. This PR addresses this by ensuring theJwtBearerHandler
gets loggers from the parent scope only. This is done as follows:ISystemLoggerFactory
interface which is used to create loggers from system-only providers.ILoggerFactory
.ScriptJwtBearerHandler
, which inheritsJwtBearerHandler
. This now importsISystemLoggerFactory
instead ofILoggerFactory
.