[Communication] - SMS - Pipeline arg is added #27321
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozgurcivi-msft
requested review from
gfeitosa-msft,
phermanov-msft and
ilyapaliakou-msft
as code owners
|
/azp run js - azure-communication-sms - tests |
|
No pipelines are associated with this pull request. |
|
API change check API changes are not detected in this pull request. |
|
/azp run js - communication-sms - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ozgurcivi-msft
requested review from
ckairen,
mikeharder,
weshaggard and
benbp
as code owners
|
/azp run js - communication-sms - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - communication-sms - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - communication-sms - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - communication-sms - tests |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run js - communication-sms - tests |
|
Azure Pipelines failed to run 1 pipeline(s). |
ozgurcivi-msft
requested review from
deyaaeldeen,
AikoBB,
maximrytych-ms and
mjafferi-msft
as code owners
|
/azp run js - communication-sms - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - communication-sms - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - communication-sms - tests |
|
Pull request contains merge conflicts. |
|
/azp run js - communication-sms - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - communication-sms - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - communication-sms - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - communication-sms - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AikoBB
reviewed
Nov 15, 2023
| @@ -80,6 +80,7 @@ | |||
| "@types/mocha": "^10.0.0", | |||
| "@types/node": "^16.0.0", | |||
| "@types/sinon": "^10.0.0", | |||
| "c8": "^8.0.1", | |||
There was a problem hiding this comment.
Hi @ozgurcivi-msft! I was wondering why the package was added to the common sdk :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists