Update rollup-plugin-node-resolve to 5.0.2 #3997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
approved these changes
Jun 21, 2019
|
/azp run js - cosmos - tests |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
bterlson
approved these changes
Jun 21, 2019
|
Looks good, but man am I looking forward to centralizing these rollup configs. |
|
/azp run js - eventhubs-client - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - eventhubs-processor - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - keyvault-keys - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - keyvault-secrets - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - storage-blob - tests |
|
/azp run js - storage-file - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - storage-queue - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
mikeharder
force-pushed
the
rollup-plugin-node-resolve-disable-tree-shaking
branch
3 times, most recently
from
d8ad15f to
f389e50
Compare
|
/azp run js - storage-blob - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
- In [email protected], rollup started respecting the "sideEffects" field in package.json. - Since our package.json sets `sideEffects=false`, this also applies to test code, which causes all tests to be removed by tree-shaking.
mikeharder
force-pushed
the
rollup-plugin-node-resolve-disable-tree-shaking
branch
from
f389e50 to
ee12b93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates dev dependency
rollup-plugin-node-resolvefrom^4.2.0to^5.0.2. This is required for compat with[email protected](rollup/rollup-plugin-node-resolve#222).Part of this PR was generated by running the following command:
There are 3 meaningful changes:
package.jsonfiles, dev dependencyrollup-plugin-node-resolvewas updated from^4.2.0to^5.0.2.pnpm-lock.yamlwas updated to the latest matching versions of all floated packages.All other changes should just be re-arranging lines in
package.json, which is done automatically by Rush.CC: @ramya-rao-a, @jonathandturner