Azure.Core 2.0: Update AzureKeyCredential, RetryPolicy, and StatusCodeClassifier #42329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annelo-msft
commented
Mar 1, 2024
annelo-msft
commented
Mar 1, 2024
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
annelo-msft
commented
Mar 1, 2024
annelo-msft
requested review from
KrzysztofCwalina,
tg-msft and
a team
as code owners
annelo-msft
requested review from
jsquire,
christothes,
AlexanderSher,
pallavit and
JoshLove-msft
annelo-msft
requested review from
quentinRobinson and
joseharriaga
as code owners
annelo-msft
added a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Mar 2, 2024
annelo-msft
commented
Mar 2, 2024
sdk/textanalytics/Azure.AI.TextAnalytics/src/TextAnalyticsFailedDetailsParser.cs
Show resolved
Hide resolved
jsquire
approved these changes
Mar 2, 2024
We don't currently have a way to un-set a property on a message, so it might be useful for this. |
christothes
reviewed
Mar 4, 2024
christothes
approved these changes
Mar 4, 2024
annelo-msft
added a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Many of the basic Azure.Core types now have analogous types in the System.ClientModel library. In order to follow the DRY engineering principle, we plan to update Azure.Core to reuse functionality from these types, using either inheritance or adapters in most cases.
This PR makes the following changes:
AzureKeyCredentialinherits from System.ClientModelApiKeyCredentialRetryPolicyadapts System.ClientModelClientRetryPolicyStatusCodeClassifieruses new internal implementation copied from System.ClientModelBitVector640Design Motivation
AzureKeyCredentialinherits fromApiKeyCredentialto reuse the implementation.RetryPolicywrapsClientRetryPolicybecause inheritance is not possible here.StatusCodeClassifierdoes not reuse anything other than a new implementation we have been meaning to move it to for a while.Context
This PR is a smaller chunk of #41773 to make it easier to review. In addition, it this PR targets the feature/azure.core-2.0 feature branch because we cannot move the Azure.Core 2.0 integration into main until after System.ClientModel 1.1.0 is GA.