Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

MsRest::ServiceClientCredentials should not be required by default #613

Closed
devigned opened this issue Dec 5, 2016 · 2 comments
Closed
Assignees
Labels
ARM bug This issue requires a change to an existing behavior in the product in order to be resolved. P2 runtime
Milestone

Comments

@devigned
Copy link
Member

devigned commented Dec 5, 2016

Given the following helloworld.json:

{
    "swagger": "2.0",
    "info": {
        "title": "HelloWorld",
        "version": "1.0.0"
    },
    "host": "swaggersample.azurewebsites.net",
    "paths": {
        "/api/HelloWorld": {
            "get": {
                "operationId": "Greeting_Get",
                "produces": [
                    "application/json"
                ],
                "responses": {
                    "200": {
                        "description": "Responds with a greeting from AutoRest",
                        "schema": {
                            "type": "string"
                        }
                    }
                }
            }
        }
    }
}

Generating code with: autorest -Input helloworld.json -Namespace 'HelloWorld' -CodeGenerator Ruby -OutputDirectory Ruby

Creates a client that required credentials in the constructor. This is incorrect and should be fixed.

@sarangan12 sarangan12 self-assigned this Dec 12, 2016
@sarangan12 sarangan12 added this to the v0.9.0-arm milestone Dec 12, 2016
@sarangan12
Copy link
Member

By default, they are assigned nil values. Closing this Issue

@devigned
Copy link
Member Author

@sarangan12, not to nit pick, but should the constructor even generate with a credentials parameter?

@vishrutshah vishrutshah added runtime bug This issue requires a change to an existing behavior in the product in order to be resolved. labels Feb 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ARM bug This issue requires a change to an existing behavior in the product in order to be resolved. P2 runtime
Projects
None yet
Development

No branches or pull requests

3 participants