New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for question mark in SAS tokens #146

Merged

MindFlavor merged 3 commits into master from issue/123/question_mark_in_sas_tokens

Jan 19, 2021

Contributor

MindFlavor commented Jan 15, 2021

Fixes #123.

This SDK now supports both SAS with or without leading question marks (as it's source of debate and we don't want to make a stand here).
Now the SDK correctly surfaces the parser error in case of malformed SAS tokens (malformed in the sense of invalid query pairs, the crate does not validate the token itself).

MindFlavor added 3 commits

January 15, 2021 11:54


          removed ? requirement in SAS tokens

c5b1c61


          surfaced SAS token error

d3e1afd


          fixed missing example

45ec254

rylev approved these changes

View reviewed changes

Contributor

rylev left a comment

This looks good to me. Using a full url parser to parse the sas token is a bit awkward probably the best way to go.

MindFlavor merged commit e543493 into master

MindFlavor deleted the issue/123/question_mark_in_sas_tokens branch

January 19, 2021 10:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet