Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize on json & xml helpers #1505

Merged
merged 4 commits into from
Dec 8, 2023
Merged

Standardize on json & xml helpers #1505

merged 4 commits into from
Dec 8, 2023

Conversation

demoray
Copy link
Contributor

@demoray demoray commented Dec 7, 2023 •
edited
Loading

In past PRs, we added centralized json & xml helpers.

This builds upon that idea by exposing helpers for Request & Response (including CollectedResponse and ResponseBody, as those are sometimes needed as well).

This significantly reduces the complexity for most of the callers and models what reqwest does for handling serialization and deserialization of requests.

This PR is broken up into multiple commits:

  1. updates to azure_core. This includes adding helpers to the Request & Response types, and making use of the helpers throughout the azure_core crate
  2. updates to the rest of the crates to use the helpers
  3. updates to azure_iot_hub to split up device & module API calls which removes the need for the caller to deal with CollectedResponse

Brian Caswell added 4 commits December 7, 2023 16:46
standardize on xml & json helpers
c5ecb06 
In past PRs, we added centralized json & xml helpers.

This builds upon that idea by exposing helpers for Request & Response
(including CollectedResponse and ResponseBody, as those are sometimes
needed as well).

This significantly reduces the complexity for _most_ of the callers and
models what `reqwest` does for handling serialization and
deserialization of requests.
update crates to normalize helper use
92dec6f
fix iot_hub's use of CollectedResponse
10d95bb
address integration test imports
9a649b5
cataggar
cataggar approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@cataggar cataggar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see these standardized.

sdk/messaging_eventgrid/src/event_grid_client.rs Show resolved Hide resolved
@demoray demoray changed the title Standardize on json xml helpers Standardize on json & xml helpers Dec 8, 2023
@demoray demoray merged commit 85d13b3 into Azure:main Dec 8, 2023
19 checks passed
@demoray demoray deleted the standardize-on-json-xml-helpers branch December 8, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cataggar cataggar cataggar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@demoray @cataggar