Get blob metadata implementation #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
approved these changes
Jan 19, 2021
| } | ||
|
|
||
| pub fn get(&self, k: &str) -> Option<Bytes> { | ||
| self.0.get(k).map(|b| b.clone()) |
There was a problem hiding this comment.
Is there a reason to eagerly clone instead of returning a &Bytes and letting the user decide? I guess cloning Bytes is fairly inexpensive....
| headers | ||
| .iter() | ||
| .filter(|header| header.0.as_str().starts_with("x-ms-meta-")) | ||
| .for_each(|header| { |
There was a problem hiding this comment.
nit: can you deconstruct the header binding as (key, value)?
There was a problem hiding this comment.
Also it's probably best to move this code to the Metadata struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115
This PR:
Done:
get_metatadata()in the blob client. The function does not require parameters and returns aGetBlobMetadataResponsewith the response headers along with the parsed metadata.Metadatastruct tobytes::Bytes(previously it wasString). This is done to better align with HeaderValue. HeaderValue does not force its contains to be a valid str so we do not require it either.ToDo:
Out of scope
Metadata poses limitations on the "key" name (it must adhere to the naming rules for C# identifiers). The SDK does not enforce it. It relies on server sides errors instead.