Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding BrokerProperties when sending message to queue or topic #1693

Merged

Conversation

Gaelik-git
Copy link
Contributor

Following this documentation : https://learn.microsoft.com/en-us/rest/api/servicebus/message-headers-and-properties#message-headers

I would like the possibility to set an ScheduledEnqueueTimeUtc (other option could be added in the future)

I updated the existing send_message method, making to modification a breaking change. Do you think it's ok like this ?
Should I create a new method for sending messages with options set ?

Thanks

@Gaelik-git Gaelik-git force-pushed the adding_brokerproperties_when_sending_message branch from c273ebe to 0ad3151 Compare July 2, 2024 11:36
Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving Service Bus SDK! One blocking comment, though. I'm okay with the break in this case, but let's not special-case too much when we do that. With an options bag, we can add more in the future without breaking.

sdk/messaging_servicebus/src/service_bus/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I just have one question/nit but otherwise LGTM. Once I get this merged, I'll publish new versions.

sdk/messaging_servicebus/src/service_bus/mod.rs Outdated Show resolved Hide resolved
@Gaelik-git Gaelik-git force-pushed the adding_brokerproperties_when_sending_message branch from ad74529 to 2c62d42 Compare August 12, 2024 16:35
@Gaelik-git
Copy link
Contributor Author

Everything should be ready, thanks for the feedback

@heaths
Copy link
Member

heaths commented Aug 12, 2024

Thank you for making the requested changes!

@heaths heaths enabled auto-merge (squash) August 12, 2024 21:58
@heaths heaths merged commit 6409e82 into Azure:main Aug 12, 2024
22 checks passed
@Gaelik-git Gaelik-git deleted the adding_brokerproperties_when_sending_message branch August 14, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants