Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EngSys][Feature] Offer an easy way to let us know if a commit ID is part of the main branch #9372

Open
ArthurMa1978 opened this issue Nov 13, 2024 · 3 comments
Open

[EngSys][Feature] Offer an easy way to let us know if a commit ID is part of the main branch #9372

ArthurMa1978 opened this issue Nov 13, 2024 · 3 comments
Labels
EngSys This issue is impacting the engineering system. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team.

Comments

@ArthurMa1978
Copy link
Member

Currently, it's difficult to determine if an SDK PR that generates code from TypeSpec is based on the main branch of our spec repo.

Since we can already support invoke the GitHub API to retrieve commit information, could EngSys provide an easy way to display this information in any SDK PRs?
@ArthurMa1978 ArthurMa1978 added the EngSys This issue is impacting the engineering system. label Nov 13, 2024
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 13, 2024
@weshaggard
Copy link
Member

What is it exactly you think would be needed here? Do you simply want to see if the sha in the tsplocation.yml file is merged into main or not? And how would you expect a PR to be marked with this information?

@raych1 don't we already have a check in the pipeline that validates this for releases?

@ArthurMa1978
Copy link
Member Author

Yes, I want to easily know it which it's not straightforward to get it now.
The pipeline validates the commit ID during release, but this validation does not occur during a PR review.

@weshaggard
Copy link
Member

If we did the validation in the PR logs and outputted a message there would that be enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
EngSys This issue is impacting the engineering system. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weshaggard @ArthurMa1978