Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to popular syntax highlighting libraries #596

Closed
sethwenzel opened this issue Oct 2, 2020 · 16 comments
Closed

Add support to popular syntax highlighting libraries #596

sethwenzel opened this issue Oct 2, 2020 · 16 comments
Labels
enhancement New feature or request

Comments

@sethwenzel
Copy link

sethwenzel commented Oct 2, 2020

Is your feature request related to a problem? Please describe.
When viewing a bicep file in AzDo Repos, can we get colorization support?

Describe the solution you'd like
Similar to other languages, can we get colorization support in Azure DevOps Repos?

Current Status:

Edited by @anthony-c-martin on 9/3/21

@sethwenzel sethwenzel added the enhancement New feature or request label Oct 2, 2020
@ghost ghost added the Needs: Triage 🔍 label Oct 2, 2020
@alex-frankel
Copy link
Collaborator

@anthony-c-martin I think you had mentioned that there is a standard package that we can be a part of to get syntax highlighting in github repos, etc. Do you know if that also works for DevOps repos?

@anthony-c-martin
Copy link
Member

anthony-c-martin commented Oct 2, 2020

GitHub uses highlightjs
DevOps uses monaco

Looks like Monaco take contributions here. We may also need to speak to the DevOps team to understand whether those are picked up by DevOps or if there's a process there.

We may also want to support linguist
And there's also prismjs

@alex-frankel alex-frankel changed the title Azure DevOps Repos support Colorization support for monaco and highlightjs Oct 14, 2020
@alex-frankel
Copy link
Collaborator

When we are ready to implement, we should reach out to DevOps Repos team to confirm requirements

@anthony-c-martin anthony-c-martin changed the title Colorization support for monaco and highlightjs Add support to popular syntax highlighting libraries Dec 15, 2020
@sebader
Copy link
Member

sebader commented Mar 12, 2021

I believe linguist is the one you need to be added to to light up on github.com. Now that bicep hopefully gets more and more traction, I would vote to prioritize this :) It's little things that this that will help people adopt it

@johnnyreilly
Copy link
Contributor

Docusaurus uses PrismJS. I raised an issue for support there when writing a Bicep blog post at the weekend:

PrismJS/prism#2816

@anthony-c-martin
Copy link
Member

I started on a prototype for TextMate (used by Linguist for GitHub syntax highlighting, and Monaco for Azure DevOps syntax highlighting).

Here's where I've put it for now: https://github.com/anthony-c-martin/bicep-textmate. Contributions are very welcome!

@slavizh
Copy link
Contributor

slavizh commented Jul 8, 2021

@anthony-c-martin Is there any timeline for this to be available in DevOps. I do not see this listed in https://docs.microsoft.com/en-us/azure/devops/release-notes/features-timeline

@anthony-c-martin
Copy link
Member

@anthony-c-martin Is there any timeline for this to be available in DevOps. I do not see this listed in https://docs.microsoft.com/en-us/azure/devops/release-notes/features-timeline

Monaco editor version 0.24 and up contain the Bicep grammar (https://www.npmjs.com/package/monaco-editor). Azure DevOps is still using version 0.20 (https://www.npmjs.com/package/vss-monaco-editor) - I'm following up internally with the team that manages the process of incorporating the latest version, but don't yet have a time frame to share. I'll post here when I have something concrete!

@anthony-c-martin
Copy link
Member

anthony-c-martin commented Sep 3, 2021

@slavizh - I've had confirmation from the DevOps team that it's been incorporated into the current release, and have seen a screenshot of Bicep highlighting working in their test environment! ETA for complete roll out is 3-5 weeks.

@johnnyreilly
Copy link
Contributor

Prismjs now has support: https://blog.johnnyreilly.com/2021/08/19/bicep-syntax-highlighting-with-prismjs

Not released yet but should be this month

@anthony-c-martin
Copy link
Member

Prismjs now has support: https://blog.johnnyreilly.com/2021/08/19/bicep-syntax-highlighting-with-prismjs

Not released yet but should be this month

NICE! Thank you so much for contributing this, that's truly awesome!!! 🎉🎉🎉

@johnnyreilly
Copy link
Contributor

johnnyreilly commented Oct 2, 2021

Happy to say that Bicep support in Prism.JS has been released! https://github.com/PrismJS/prism/releases/tag/v1.25.0

Hopefully support will be available in Shiki in future: shikijs/shiki#239

@anthony-c-martin
Copy link
Member

@anthony-c-martin Is there any timeline for this to be available in DevOps. I do not see this listed in https://docs.microsoft.com/en-us/azure/devops/release-notes/features-timeline

@slavizh - Looks like this has been deployed now!

@slavizh
Copy link
Contributor

slavizh commented Oct 12, 2021

@anthony-c-martin yes I can see it now on our DevOps. Thank you Anthony for making it happen and follow trough.

@anthony-c-martin
Copy link
Member

Closing this out as we've added support to the major libraries planned above. Please create new issues for adding support to new libraries, or to report issues with existing ones.

@miqm
Copy link
Collaborator

miqm commented Aug 4, 2022

do we have a js file built for highlightjs so we can register it as a language?

@ghost ghost locked as resolved and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants