Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema Inconsistencies #845

Closed
apybar opened this issue Jan 7, 2025 · 3 comments · Fixed by #869
Closed

Schema Inconsistencies #845

apybar opened this issue Jan 7, 2025 · 3 comments · Fixed by #869
Assignees
Labels
bug Something isn't working

Comments

@apybar
Copy link
Collaborator

apybar commented Jan 7, 2025

Noticing Inconsistencies with some schemas - documentation for example.

assigning to myself

@apybar apybar added the bug Something isn't working label Jan 7, 2025
@apybar apybar self-assigned this Jan 7, 2025
@cyrilzhouibo
Copy link
Contributor

@apybar Thanks for opening this bug. I found some issues in https://raw.githubusercontent.com/Azure/enterprise-azure-policy-as-code/main/Schemas/policy-documentation-schema.json. Could you please fix them together in this bug?

  1. Regarding "environmentCategories".
Image

The environmentCategories is not defined in the properties.

  1. Regarding "policy set name"
Image

custom policy requires "name" in stead of "id". So it should be:

Image

@andersthorbeck
Copy link

I've noticed that the exemptions documentation documents (and recommends) the scopes property, whereas this property is missing from the actual exemption JSON schema.

Aren't the schema files automatically updated when new functionality is supported? Surely they should be?

@apybar
Copy link
Collaborator Author

apybar commented Feb 1, 2025

@cyrilzhouibo - I've updated this on my latest push, hopefully will be part of the release we are planning for Monday/Tuesday this week.

@andersthorbeck - Can you please show where it is missing from the exemption JSON schema?

I'm seeing it here:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants