-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add the takeover how-to doc (preview) #967
Open
michaelawyu
wants to merge
2
commits into
Azure:main
Choose a base branch
from
michaelawyu:docs/takeover
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/howtos/takeover.md
Outdated
|
||
## Takeover and comparison options | ||
|
||
> See the how-to guide on drift detection for an explaination on comparison options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
> See the how-to guide on drift detection for an explaination on comparison options. | |
> See the how-to guide on drift detection for an explanation on comparison options. |
ryanzhang-oss
approved these changes
Nov 23, 2024
docs/howtos/takeover.md
Outdated
Comment on lines
79
to
88
# For simplicity reasons, the CRP is configured to roll out changes to | ||
# all member clusters at once. This is not a setup recommended for production | ||
# use. | ||
type: RollingUpdate | ||
rollingUpdate: | ||
maxUnavailable: 100% | ||
unavailablePeriodSeconds: 1 | ||
applyStrategy: | ||
whenToTakeOver: IfNoDiff | ||
EOF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
# For simplicity reasons, the CRP is configured to roll out changes to | |
# all member clusters at once. This is not a setup recommended for production | |
# use. | |
type: RollingUpdate | |
rollingUpdate: | |
maxUnavailable: 100% | |
unavailablePeriodSeconds: 1 | |
applyStrategy: | |
whenToTakeOver: IfNoDiff | |
EOF | |
# For simplicity reasons, the CRP is configured to roll out changes to | |
# all member clusters at once. This is not a setup recommended for production | |
# use. | |
type: RollingUpdate | |
rollingUpdate: | |
maxUnavailable: 100% | |
unavailablePeriodSeconds: 1 | |
applyStrategy: | |
whenToTakeOver: IfNoDiff | |
EOF |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds a how-to doc for the new takeover experience.
I have:
make reviewable
to ensure this PR is ready for review.How has this code been tested
N/A
Special notes for your reviewer