Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can Receiver.unsettledMessages be a count? #317

Closed
jhendrixMSFT opened this issue Jan 5, 2024 · 1 comment · Fixed by #318
Closed

Can Receiver.unsettledMessages be a count? #317

jhendrixMSFT opened this issue Jan 5, 2024 · 1 comment · Fixed by #318

Comments

@jhendrixMSFT
Copy link
Member

We had an issue where cross-receiver message settlement caused a memory leak as entries in the unsettledMessages map weren't deleted. While this has been fixed, it brings up the question of whether unsettledMessages really needs to be a map or just an atomically accessed count.
@jhendrixMSFT jhendrixMSFT mentioned this issue Jan 16, 2024
Closed
@jhendrixMSFT
Copy link
Member Author

While we can switch to using a count, it would prevent us from properly implementing suspend/resume links.

@jhendrixMSFT jhendrixMSFT mentioned this issue Jan 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Track receiver's unsettled messages as a count jhendrixMSFT/go-amqp
1 participant
@jhendrixMSFT