-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update prometheus.rules.json with new schema #997
base: main
Are you sure you want to change the base?
Conversation
Thanks for your PR @monteiro-renato . |
@moshemal - can one of you validate this data type addition for expr and approve, after which we can merge ? |
@microsoft-github-policy-service agree |
30fd4d2
to
566ce2b
Compare
This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Still interested but awaiting feedback from codeowners. |
/azp run |
No pipelines are associated with this pull request. |
971c106
to
db2f701
Compare
I noticed a new PR will fix the tests > #1008 so I reverted my changes and this PR will only have the changes to the schema. |
This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Still interested but awaiting feedback from codeowners. |
@moshemal - please check and review the schema changes and add Noam if needed... |
/azp run |
No pipelines are associated with this pull request. |
Hey 👋 Here's an example of what I was trying to deploy initially and failing due to the schema only accepting strings in the expr field: |
Partial yaml config:
|
Related with > SchemaStore/schemastore#4148