-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"dotnet msbuild /t:package" doesn't work #907
Comments
I'm having the same issue. I'd love to see this "just work" with |
We support dotnet core services, but the application project (*.sfproj) is still '.Net Framework', so dotnet msbuild is not supported. |
@ravipal, yes, I understand it, but the problem that from one side Do you know if there are any close plans to fix such incompatibilities? E.g. adding support for *.sfproj in new format, to make it fully compatible with .NET Core projects, or maybe something else? |
I'm sad that one year later this is still an issue :(
This is for the moment the quickest way to build an SF solution mixing dotnet core projects and SF project. |
We are doing something similar where we do:
But we found that msbuild /t:package always execute build instead of just packaging. Is there a way to skip build when packaging? |
Why not |
@devlie you should be able to remove |
@abatishchev , as far as I know, @klettier I could have, but |
Right! It doesn't. Sorry, got confused. We're using "raw" nuspec to package SF: pkg -> sfpkg -> nupkg. |
Hello from the year 2021 A.D. The sfproj file format is still very much in Framework (and required a This issue that seems relevant: #885 |
My team has been on (unsupported) dotnet build of sfproj for about 6 months and it appears stable. You linked to the relevant thread, workaround provided there. But I understand your frustration -- a supported approach would be preferable. @masnider Engaged the sfproj owners on that thread to try and get you a better answer there. |
Thanks for the suggestion, but, as you suspected, we need something more official for our official development. Although it wouldn't hurt to do a proof of concept with that solution for my own personal Service Fabric knowledge. |
Not sure if it was already discussed - I found some similar topics, but still not exactly same.
I got some real challenges mixing Service Fabric and .NET Core solution.
Through Visual Studio and using
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\15.0\Bin\msbuild.exe myproj.csproj /t:package
- everything builds and works fine. However it's not possible to build it on other machines with no VS2017 installed (e.g. CI server), eventhough there is latest .NET Core SDK present.So the issue is:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\15.0\Bin\msbuild.exe myproj.csproj /t:package
- worksBut:
dotnet msbuild myproj.csproj /t:package
- doesn't work and throws:There is an older Visual Studio 2015 present with msbuild 14.0 on CI server, but it also doesn't work, because it fails to parse .NET Core *.csproj files.
Is it really the only option to install VS2017 on CI server? My first impression was that
dotnet msbuild
is same asmsbuild.exe
and self-sufficient without VS2017. Also in Microsoft docs (https://docs.microsoft.com/en-us/visualstudio/msbuild/what-s-new-in-msbuild-15-0) it says -MSBuild is now available as part of the .NET Core SDK and can build .NET Core projects on Windows, macOS, and Linux.
Am I doing something wrong, or is it a known issue? Can it be workarounded somehow? Currently *.sfproj files look a bit outdated comparing to .NET Core projects - which is not bad in general, but it's just hard to mix these two worlds.. I have a feeling that we either need to drop .NET Core, or Service Fabric in our project..
Update:
I also investigated VS2017 Build Tools, which is a separate thing, not needed to have VS2017 installed. It sounds like a good option for CI builds, however this guy doesn't have proper support for .NET Core projects.. (related issue - dotnet/msbuild#1697). So once again - it's hard to mix both worlds.
The text was updated successfully, but these errors were encountered: