Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: deploy_diagnostics_for_mg variable does not trigger diagnostics deployment #672

Closed
MarcelHeek opened this issue Apr 6, 2023 · 6 comments
Assignees

Comments

@MarcelHeek
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Versions

terraform: 1.3.9

azure provider: 3.50.0

module: 3.3.0

Description : Deploy diagnostics for MG is not triggered.

Describe the bug

Although bumped up to module version 3.3.0 and AzureRM version 3.50.0 and adding the variable to the enterprise_scale.tfvars the plan show no changes to be made that reflect the enabling of diagnostics on Management Groups

Steps to Reproduce

Up the version of the terraform-azurerm-caf-enterprise-scale module in our workflow (Rover based), see screenshot
image

The plan output only show 1 outside changes and 1 policy assignments change, thats are both non-related to enabling diagnostics on Management Groups

Screenshots

Additional context

Please advice.....

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Apr 6, 2023
@MarcelHeek
Copy link
Author

@lachaves Do you perhaps have an idea why this is not working for me?

@matt-FFFFFF
Copy link
Member

Hi @MarcelHeek

The MG diag settings are deployed by the AzAPI provider. Can you confirm this is being used?

We do not test this module with Rover and the aztfmod caf supermodule. You should raise an issue on that repo as well.

@matt-FFFFFF matt-FFFFFF self-assigned this Apr 25, 2023
@ghost ghost removed the Needs: Triage 🔍 Needs triaging by the team label Apr 25, 2023
@MarcelHeek
Copy link
Author

Hi @matt-FFFFFF,

How can I confirm whether this is being used? I am not that much into TF and merely a consumer. I can (at this point) only see that the azure/azapi module v1.5.0 is being loaded through the enterprise-scale module load in the Azure/caf-terraform-landingzone logic

And I will look into raising this issue as well in the Azure/caf-terraform-landingzone repo which calls the enterprise_scale module (as a caf solution add-on)

@lachaves
Copy link
Contributor

Hi @MarcelHeek, looking into it right now.

@MarcelHeek
Copy link
Author

@lachaves It's been a while, but diagnostics for MG's are still not set for our tenants. I have the required versions of the providers in place that are documented here

As you can see in this screenshot the version requirements are all met
image

Have you any idea what might be the issue?

@matt-FFFFFF
Copy link
Member

closed by #1053

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants