Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 using node.js 16 upgrade to node.js 20 seeing 16 is deprecated #392

Closed
MV-PDM opened this issue Jan 25, 2024 · 16 comments
Closed

V3 using node.js 16 upgrade to node.js 20 seeing 16 is deprecated #392

MV-PDM opened this issue Jan 25, 2024 · 16 comments
Assignees

Comments

@MV-PDM
Copy link

MV-PDM commented Jan 25, 2024

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: azure/webapps-deploy@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Does not take a node.js version either

runs:
  using: 'node20'
@surenderssm
Copy link
Member

ACK on the need to move to NODE:20. This is in our scope, will keep the forum updated.
cc : @kumaraksh1

@michealmueller
Copy link

michealmueller commented Jan 25, 2024

i am also running into this today, do we have an ETA or hotfix/workaround or release?

or perhaps a different gh action till this is sorted?

@RudiSzalai
Copy link

It is hard to believe that there is this little interest in this issue. What do other people use to deploy web apps in Azure??

@MV-PDM
Copy link
Author

MV-PDM commented Feb 5, 2024

It is hard to believe that there is this little interest in this issue. What do other people use to deploy web apps in Azure??
@RudiSzalai

No idea. the most problematic issue is that it really only requires to update the node version in the action.yml

from:
runs: using: 'node16'

to:
runs: using: 'node20'

@jlaundry
Copy link

jlaundry commented Feb 8, 2024

Looks like there are 2x PRs for this: #393 and #397 (both have exactly the same 1-line change, #397 tests have run and passed)

@VaclavElias
Copy link

This needs to be done also for v2. Another reference #372

@DThorpFF
Copy link

Looks like there are 2x PRs for this: #393 and #397 (both have exactly the same 1-line change, #397 tests have run and passed)

Is there an estimated time for when this will be merged?

@martincostello
Copy link
Contributor

GitHub Actions; All Actions will run on Node20 instead of Node16 by default

Following on from our warning in workflows using Node16 we will start enforcing the use of Node20 rather than Node16 on the 13th of May.

@MV-PDM
Copy link
Author

MV-PDM commented Mar 7, 2024

@martincostello:

GitHub Actions; All Actions will run on Node20 instead of Node16 by default

Following on from our warning in workflows using Node16 we will start enforcing the use of Node20 rather than Node16 on the 13th of May.

@surenderssm @KumarAksh please note the above.

@Piedone
Copy link

Piedone commented Mar 11, 2024

Duplicate of: #372

@leandromsft
Copy link

I´m using v3 and result this warning

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: Azure/webapps-deploy@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

@peter5000
Copy link

Is there any update on this thread? I am having the same issue as leandromsft. I changed azure/webapps-deploy@v2 to azure/webapps-deploy@v3 in my yml file, but it shows the same warning

@michealmueller
Copy link

michealmueller commented Mar 21, 2024 via email

@danielz-nenda
Copy link

Submitted a Azure support request regarding this, we'll see if that helps.

@ShilpiRachna1
Copy link
Collaborator

This issue has been fixed for webapps_deploy@v2 and webapps_deploy@v3. I apologise for the delay.

FYI - @MV-PDM , @michealmueller , @RudiSzalai , @danielz-nenda , @peter5000 , @leandromsft , @martincostello , @Piedone , @VaclavElias , @DThorpFF , @jlaundry

@Piedone
Copy link

Piedone commented Apr 10, 2024

Great! Shouldn't then this issue and #372 be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests