Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Revert breaking changes in JsonSerializerPrimitives #2943

Open
keegan-caruso opened this issue Oct 25, 2024 · 1 comment
Open
Labels
Customer reported Indicates issue was opened by customer Dependency Mismatch Transitive dependency might be at play and create issues resulting in incorrect versions of a class P1 More important, prioritize highly

Comments

@keegan-caruso
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Many issues have been raised both in this repo, asp.net core, and Owin. Since this repo uses InternalsVisible, any APIs used across assemblies must be treated as public.

Describe the solution you'd like

Remove breaking changes between 7.x and 8.x Identity Model. The most problematic one is likely this: #2491

No breaking changes, only new APIs that get called, such that mismatched version still call a method that exists and doesn't have breaking behavioral changes.

Adding PublicAPI Analyzers to the 7x branch could help with understanding the API diffs.

Describe alternatives you've considered

Analyzers for mismatched version could help looking forward, but it isn't the right solution here.

Additional context

#2513 (comment)

cc @halter73

@keegan-caruso keegan-caruso added needs attention untriaged Customer reported Indicates issue was opened by customer Dependency Mismatch Transitive dependency might be at play and create issues resulting in incorrect versions of a class and removed needs attention untriaged labels Oct 25, 2024
@keegan-caruso
Copy link
Contributor Author

I think this needs to be fixed in 8x, but we also need to spend some time looking at our 8x -> 9x story for this class of issue and include explicit testing of mismatched 8x/9x versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer reported Indicates issue was opened by customer Dependency Mismatch Transitive dependency might be at play and create issues resulting in incorrect versions of a class P1 More important, prioritize highly
Projects
None yet
Development

No branches or pull requests

1 participant