Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] New validation call graph needs a way to defer building strings. #2986

Open
brentschmaltz opened this issue Nov 7, 2024 · 0 comments
Open

[Feature Request] New validation call graph needs a way to defer building strings. #2986

brentschmaltz opened this issue Nov 7, 2024 · 0 comments
Labels
Enhancement The issue is a new feature Internal Indicates issue was opened by the IdentityModel team

Comments

@brentschmaltz
Copy link
Member

One of the tenants of the new design is to reduce allocations when multiple policies are in effect. So if the first policy fails and the second policy succeeds, we want minimal allocations.

Several places in our call graphs we build strings when multiple errors could have occurred, signature validation is one place.
We need to find a way to build the strings on demand.
@brentschmaltz brentschmaltz mentioned this issue Nov 7, 2024
Merged
@pmaytak pmaytak added Enhancement The issue is a new feature and removed needs attention untriaged labels Nov 7, 2024
@keegan-caruso keegan-caruso added the Internal Indicates issue was opened by the IdentityModel team label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement The issue is a new feature Internal Indicates issue was opened by the IdentityModel team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brentschmaltz @pmaytak @keegan-caruso