New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid sync over async in Microsoft.IdentityModel.Protocols #3025

Open

vwxyzh opened this issue Nov 21, 2024 · 1 comment

Labels

sync-over-async

vwxyzh commented Nov 21, 2024

https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/blame/c5396a47c58b32616669f448563b79edc2af2531/src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs#L240

suggest following code:

private async Task UpdateCurrentConfiguration()
{
   //...
   T configuration = await _configRetriever.GetConfigurationAsync(
                    MetadataAddress,
                    _docRetriever,
                    CancellationToken.None).ConfigureAwait(false);
   //...

jennyf19 added the sync-over-async label

Member

brentschmaltz commented Nov 25, 2024

@vwxyzh what issue are you looking to solve?

jennyf19 mentioned this issue

[Feature Request] Add new api RequestRefreshAsync(). #3040

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment