Guard logging calls to avoid unnecessary work at call site (#2164) #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many LogHelper.Log calls are doing work at the call site, such as allocating params arrays, boxing structs, formatting strings, and so on, even when the data will be thrown away because logging (or logging for that verbosity level) isn't enabled. This adds an IsEnabled method to LogHelper and uses it at any call site where there's such work to be avoided.
keegan-caruso
approved these changes
Jul 28, 2023
jennyf19
reviewed
Jul 28, 2023
henrik-me
reviewed
Jul 28, 2023
| } | ||
| else | ||
| { | ||
| // Skip the element since it is not an <RSAKeyValue> | ||
| LogHelper.LogWarning(LogMessages.IDX30300, reader.ReadOuterXml()); | ||
| reader.Skip(); | ||
| } |
There was a problem hiding this comment.
looks like changed behavior. @keegan-caruso @brentschmaltz @jennyf19 assuming no tests are failing, however would be good to assess this change for any potential impact (perhaps not relevant as the reader.ReadEndElement does this implicitly already.
Same comment below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is Stephen's PR originally committed into dev7x.
Many LogHelper.Log calls are doing work at the call site, such as allocating params arrays, boxing structs, formatting strings, and so on, even when the data will be thrown away because logging (or logging for that verbosity level) isn't enabled. This adds an IsEnabled method to LogHelper and uses it at any call site where there's such work to be avoided.