Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial regression tests for the new validation path #2810

Merged
merged 10 commits into from
Sep 4, 2024

Conversation

iNinja
Copy link
Contributor

@iNinja iNinja commented Sep 4, 2024

Add initial regression tests for the new validation path

Description

Added theory based test for comparing the ValidationParameters based new token validation path against JsonWebTokenHandler's original path with TokenValidationParameters.

More tests are being added as a follow up.

Part of #2711

…ValidationParameters and ValidationParameters

Added error message when validating a signature and the key is not found using the kid, without trying all keys
# Conflicts:
#	src/Microsoft.IdentityModel.JsonWebTokens/JsonWebTokenHandler.ValidateSignature.cs
@iNinja iNinja requested a review from a team as a code owner September 4, 2024 14:26
iNinja and others added 3 commits September 4, 2024 16:33
Added ctor JsonWebTokenHandlerValidationParametersTheoryData to take TestId.
@brentschmaltz brentschmaltz merged commit 1619c36 into dev Sep 4, 2024
6 checks passed
@jennyf19 jennyf19 added this to the 8.0.3 milestone Sep 20, 2024
@brentschmaltz brentschmaltz deleted the iinglese/add-regression-tests branch October 23, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants