Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Code Cleanup in Microsoft.Identity.Web.UI AccountController #232

Closed
1 task
jmprieur opened this issue Jun 23, 2020 · 3 comments
Closed
1 task

[Bug] Code Cleanup in Microsoft.Identity.Web.UI AccountController #232

jmprieur opened this issue Jun 23, 2020 · 3 comments

Comments

@jmprieur
Copy link
Collaborator

jmprieur commented Jun 23, 2020

Which Version of Microsoft Identity Web are you using ?
Microsoft Identity Web 0.1.5-preview

Where is the issue?

  • Web App
    • [x ] Sign-in users
    • Sign-in users and call web APIs

Suggestions

  • AccountController uses IOptionsMonitor whereas the rest of Microsoft.Identity.Web.UI uses IOptions. The recommendation is to use IOptions
  • AccountController sets explicitly a scheme value whereas Chris recommends to just use null (which challenges the default provider)

Note
The AzureAD.UI counterpart does the same as Microsoft.Identity.Web.UI's account controller.

@jmprieur jmprieur added bug Something isn't working P3 .NET Core 5 labels Jun 23, 2020
@jmprieur
Copy link
Collaborator Author

@Tratcher FYI

@jmprieur jmprieur added code cleanup and removed bug Something isn't working labels Jun 24, 2020
@Tratcher
Copy link

  • AccountController sets explicitly a scheme value whereas Chris recommends to just use null (which challenges the default provider)

I checked on this and found that the auth scheme is only required to be non-null for SignIn. I've filed dotnet/aspnetcore#23325 to fix that. You can remove the fallback for all of the others.

@jennyf19
Copy link
Collaborator

Included in 0.2.0-preview release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants