Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Rename MsalMemoryTokenCacheOptions.SlidingExpiration to AbsoluteExpirationRelativeToNow #250

Closed
7 tasks
jmprieur opened this issue Jun 24, 2020 · 2 comments
Closed
7 tasks

[Bug] Rename MsalMemoryTokenCacheOptions.SlidingExpiration to AbsoluteExpirationRelativeToNow #250

jmprieur opened this issue Jun 24, 2020 · 2 comments
Assignees
@jennyf19
Labels
API-breaking-change bug Something isn't working fixed .NET Core 5 P1 reported-by-aspnetcore
Milestone
[1] .NET 5 Readin...

Comments

@jmprieur
Copy link
Collaborator

jmprieur commented Jun 24, 2020 •
edited
Loading

Which Version of Microsoft Identity Web are you using ?
Microsoft Identity Web 0.1.5-preview

Where is the issue?

  • Web App
    • Sign-in users
    • Sign-in users and call web APIs
  • Web API
    • Protected web APIs (Validating tokens)
    • Protected web APIs (Validating scopes)
    • Protected web APIs call downstream web APIs
  • Token cache serialization
    • [x ] In Memory caches
    • Session caches
    • Distributed caches

Repro
MsalMemoryTokenCacheOptions.SlidingExpiration should be named AbsoluteExpirationRelativeToNow

MsalMemoryTokenCacheProvider.cs#L80

whereas the In memory cache uses absoluteExpirationRelativeToNow
@jmprieur
Copy link
Collaborator Author

Adding P1 as there is an API breaking change (do it sooner rather than later)

@jennyf19 jennyf19 self-assigned this Jun 24, 2020
@jennyf19 jennyf19 mentioned this issue Jun 24, 2020
Merged
@jennyf19
Copy link
Collaborator

Included in 0.2.0-preview release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jennyf19 jennyf19

Labels
API-breaking-change bug Something isn't working fixed .NET Core 5 P1 reported-by-aspnetcore
Projects
None yet
Milestone
[1] .NET 5 Readiness - 0.2.0-preview
Development

No branches or pull requests
2 participants
@jmprieur @jennyf19