You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's historical and needs to be changed
We should not inject the IOptions<DistributedCacheEntryOptions> (because different components could be using different caches and would need to have different options)
What needs to be done?
SessionTokenCache does not need option, it uses the session options
Add a MsalDistributedTokenCacheAdapterOptions class inheriting from DistributedCacheEntryOptions, and use this one in lieu of DistributedCacheEntryOptions in MsalDistributedTokenCacheAdapter.cs (as other components would want to use the ASP.NET Core provided distributed cache)
update the wiki documentation to mention the new option.
The text was updated successfully, but these errors were encountered:
Which Version of Microsoft Identity Web are you using ?
Microsoft Identity Web 0.1.5-preview
MsalMemoryTokenCacheProvider
get its own options type butMsalDistributedTokenCacheAdapter
injectsIOptions<DistributedCacheEntryOptions>
?microsoft-identity-web/src/Microsoft.Identity.Web/TokenCacheProviders/Distributed/MsalDistributedTokenCacheAdapter.cs
Line 38 in 17f48c6
microsoft-identity-web/src/Microsoft.Identity.Web/TokenCacheProviders/InMemory/MsalMemoryTokenCacheProvider.cs
Line 39 in 17f48c6
It's historical and needs to be changed
We should not inject the
IOptions<DistributedCacheEntryOptions>
(because different components could be using different caches and would need to have different options)What needs to be done?
SessionTokenCache
does not need option, it uses the session optionsMsalMemoryTokenCacheProvider.cs
already has options, which we'll keep.MsalDistributedTokenCacheAdapterOptions
class inheriting fromDistributedCacheEntryOptions
, and use this one in lieu ofDistributedCacheEntryOptions
in MsalDistributedTokenCacheAdapter.cs (as other components would want to use the ASP.NET Core provided distributed cache)The text was updated successfully, but these errors were encountered: