Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Re-enable UI tests for AAD apps once the lab users MFA is fixed #2716

Closed
jmprieur opened this issue Mar 24, 2024 · 1 comment · Fixed by #2755
Closed

[Feature Request] Re-enable UI tests for AAD apps once the lab users MFA is fixed #2716

jmprieur opened this issue Mar 24, 2024 · 1 comment · Fixed by #2755
Labels
enhancement New feature or request feature request

Comments

@jmprieur
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently the UI tests ChallengeUser_MicrosoftIdFlow_LocalApp_ValidEmailPassword and ChallengeUser_MicrosoftIdFlow_LocalApp_ValidEmailPasswordCreds_TodoAppFunctionsCorrectly fail because the lab user needs to setup MFA, and execute MFA

Describe the solution you'd like
Once the lab users are usable, re-enable these tests
jmprieur added a commit that referenced this issue Mar 24, 2024
@jmprieur
Fixing tests due to directory clean-up
b705423 
Disabling UI tests that require MFA until we find a solution to #2716
jmprieur added a commit that referenced this issue Mar 24, 2024
@jmprieur
Update the appId (#2715)
4d58560 
* Update the appId

* Fixing tests due to directory clean-up
Disabling UI tests that require MFA until we find a solution to #2716
@bgavrilMS
Copy link
Member

This happens because you are using the msidentitytesting.onmicrosofonline.com and MFA is mandatory in this tenant. Correct solution is to change to use the lab tenant (the lab response has the value) - this doesn't mandate MFA.

jmprieur added a commit that referenced this issue Apr 13, 2024
@jmprieur
Fixes #2716 by moving almost all tests to the Lab
e721d90
@jmprieur jmprieur mentioned this issue Apr 13, 2024
Merged
jmprieur added a commit that referenced this issue Apr 13, 2024
@jmprieur
Fixes #2716 by moving almost all tests to the Lab (#2755)
0823003 
* Fixes #2716 by moving almost all tests to the Lab

* Disabling the graph service client aspects until admin consent
jmprieur added a commit that referenced this issue Apr 13, 2024
@jmprieur
Fixes #2716 by moving almost all tests to the Lab (#2755)
36ac00f 
* Fixes #2716 by moving almost all tests to the Lab

* Disabling the graph service client aspects until admin consent
@jmprieur jmprieur mentioned this issue Apr 13, 2024
Merged
jmprieur added a commit that referenced this issue Apr 13, 2024
@jmprieur
Fixes #2716 by moving almost all tests to the Lab (#2755) (#2757)
5e89be2 
* Fixes #2716 by moving almost all tests to the Lab

* Disabling the graph service client aspects until admin consent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #2716 by moving almost all tests to the Lab AzureAD/microsoft-identity-web
2 participants
@bgavrilMS @jmprieur