Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update website #20

Merged
merged 1 commit into from
Mar 27, 2018
Merged

Update website #20

merged 1 commit into from
Mar 27, 2018

Conversation

jeffsieu
Copy link
Contributor

@jeffsieu jeffsieu commented Jan 7, 2018

Resolves #19 #10

This commit contains the following changes:

  • Add home redirection on menu bar logo
  • Update copyright year to 2018
  • Fix hovering over "Solid Modeling" causing container to resize
  • Fix "necassary" typo Join Us!
  • Fix minor typo in Free & Open section
  • Wrap sections with containers for better large-screen support
  • Add mailing list subscriptions
  • Make menu collapse for small screens
  • Beautify and standardize all non-library javascript files to use 4-space indentation
  • Beautify index.html

Add home redirection on menu bar logo
Update copyright year to 2018
Fix "necassary" typo Join Us!
Fix minor typo in Free & Open section
Wrap sections with containers for better large-screen support
Add mailing list subscriptions
Make menu collapse for small screens
Beautify and standardize all non-library javascript files to use 4-space indentation
Beautify index.html
@brlcad
Copy link
Member

brlcad commented Mar 27, 2018

@jeffsieu it's generally a really bad idea to mix code beautification/indentation/style changes in with other code changes. if anything, to keep them as separate commits instead of squashing into one so the logic changes can be inspected more carefully.

I want to merge this but it'll essentially be on blind faith that there aren't issues or undesirable changes

@brlcad brlcad merged commit 896d7f1 into BRL-CAD:master Mar 27, 2018
@brlcad brlcad mentioned this pull request Mar 27, 2018
starseeker pushed a commit that referenced this pull request Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants