Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::random in select statistical tests to avoid circular arguments. #117

Open
rileyjmurray opened this issue Sep 15, 2024 · 0 comments

Comments

@rileyjmurray
Copy link
Contributor

Our tests for the subspace embedding properties of Gaussian and uniform operators rely on a probabilistic analysis of the power method. That analysis assumes the initial vector is drawn uniformly from the unit sphere. It isn't appropriate to use our internal functions for sampling from the Gaussian distribution to draw this vector. Instead, we can use the normal distribution in the C++ STL with the Mersenne Twister as the underlying engine.

Interesting fact: C++26 will ship with Philox in the STL!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant