Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset processing fails with single wavelength #14

Open
IbkPLT opened this issue Nov 22, 2024 · 0 comments · May be fixed by #15
Open

Dataset processing fails with single wavelength #14

IbkPLT opened this issue Nov 22, 2024 · 0 comments · May be fixed by #15

Comments

@IbkPLT
Copy link

IbkPLT commented Nov 22, 2024

Processing multiple chromatograms with less than 4 wavelengths (single wavelength detector) fails due to
"smooth_wl": max(len(self.wavelength()) // 20, 4), in line 298 of dataset.py.

A possible fix is "smooth_wl": max(len(self.wavelength()) // 20, 4) if len(self.wavelength()) >= 4 else None, to ensure that more than 3 wavelengths are present for the SG filter.

@IbkPLT IbkPLT linked a pull request Nov 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant