This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Optimize layer panel #333
Merged
Optimize layer panel #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stazrad
commented
Aug 25, 2021
| } | ||
| }) | ||
|
|
||
| handleFeatureDoubleClick = memo(this.props.handleFeatureDoubleClick) |
There was a problem hiding this comment.
the memo wrappers here make sure that every feature item that is rendered have callbacks pointing to the same instance of these methods (instead of instantiating a new function for each feature)
stazrad
commented
Aug 25, 2021
stazrad
added
pending changes
stazrad
commented
Aug 30, 2021
package.json
Outdated
| @@ -100,6 +100,7 @@ | |||
| "react-hook-form": "~5.7.2", | |||
| "react-select": "~3.1.0", | |||
| "react-viewer": "^3.2.2", | |||
| "react-virtuoso": "^1.10.8", | |||
stazrad
commented
Sep 20, 2021
| ref={this.virtuoso} | ||
| itemContent={this.renderFeatureRow} | ||
| rangeChanged={this.handleRangeChange} | ||
| initialItemCount={data.length > 6 ? 6 : data.length} |
drodenberg
approved these changes
Sep 20, 2021
stazrad
added
ready to ship 🚀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #280
PR Safety Checklist:
package.json&package-lock.jsonversion numbers to appropriate releasenpm run docsQuick Description of Changes (+ screenshots for ui changes):
This optimization improves performance in LayerPanel when large feature sets are being rendered.
BEFORE (delay to expand after click is not obvious in the screen capture):
Screen.Recording.2021-08-25.at.1.33.14.AM.mov
AFTER (features list renders instantly on click without blocking threads):
Screen.Recording.2021-08-25.at.1.32.32.AM.mov